You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/07/15 16:12:23 UTC
[GitHub] [lucene-solr] dsmiley opened a new pull request #1672: SOLR-14651: Metrics History could disable better
dsmiley opened a new pull request #1672:
URL: https://github.com/apache/lucene-solr/pull/1672
* SolrRrdBackendFactory should not be created if history is disabled
* Disable MetricsHistoryHandler by default in tests
* Await shutdown of all executors
Interestingly, all tests passed with the history handler disabled. Isn't that a problem @sigram ?
Somewhat related: I'm also inclined to make a little refactor in CoreContainer.shutdown such that `IOUtils.closeQuietly(metricsHistoryHandler.getSolrClient());` can move _into_ metricsHistoryHandler.close()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1672: SOLR-14651: Metrics History could disable better
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1672:
URL: https://github.com/apache/lucene-solr/pull/1672#issuecomment-663935133
I see @markrmiller did something similar at about the same time: https://github.com/apache/lucene-solr/commit/a7b9847a7e98c27d74b13ac0a46d3e36945fbba3 but instead more completely disabled it, not just the RRD aspect. And it's purely for tests, as opposed to the PR here that has a production aspect if you choose to configure to disable the RRD.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley merged pull request #1672: SOLR-14651: Metrics History could disable better
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #1672:
URL: https://github.com/apache/lucene-solr/pull/1672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1672: SOLR-14651: Metrics History could disable better
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1672:
URL: https://github.com/apache/lucene-solr/pull/1672#issuecomment-659887861
You might like this one @markrmiller
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] sigram commented on a change in pull request #1672: SOLR-14651: Metrics History could disable better
Posted by GitBox <gi...@apache.org>.
sigram commented on a change in pull request #1672:
URL: https://github.com/apache/lucene-solr/pull/1672#discussion_r461682200
##########
File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java
##########
@@ -77,6 +77,12 @@ public static void shutdownAndAwaitTermination(ExecutorService pool) {
awaitTermination(pool);
}
+ public static void shutdownNowAndAwaitTermination(ExecutorService pool) {
+ if(pool == null) return;
Review comment:
missing space after `if`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org