[GitHub] mdespriee edited a comment on issue #12489: [WIP][MXNET-918] Random api

[GitBox <gi...@apache.org>]

mdespriee edited a comment on issue #12489: [WIP][MXNET-918] Random api
URL: https://github.com/apache/incubator-mxnet/pull/12489#issuecomment-421831411
 
 
   @lanking520. Underscore removed. We now have this kind of signatures:
   ```
   def random_normal (loc : Option[org.apache.mxnet.Base.MXFloat] = None, scale : Option[org.apache.mxnet.Base.MXFloat] = None, shape : Option[org.apache.mxnet.Shape] = None, ctx : Option[String] = None, dtype : Option[String] = None, name : String = null, attr : Map[String, String] = null) : org.apache.mxnet.Symbol
   ```
   and
   ```
   def sample_normal (mu : Option[org.apache.mxnet.Symbol] = None, shape : Option[org.apache.mxnet.Shape] = None, dtype : Option[String] = None, sigma : Option[org.apache.mxnet.Symbol] = None, name : String = null, attr : Map[String, String] = null) : org.apache.mxnet.Symbol
   ```
   
   I don't think we can go further. If remove both `_random_` and `_sample_` prefixes, we'll have collisions that the scala compiler can't resolve since all parameters have default values.
   (`multiple overloaded alternatives of method uniform define default arguments`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services