[GitHub] [incubator-uniffle] jerqi commented on pull request #783: [#782]refactor: restrict rss.rpc.server.type to an enum

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on PR #783:
URL: https://github.com/apache/incubator-uniffle/pull/783#issuecomment-1493555230

   > > > > Should we add some check in the line
   > > > > https://github.com/apache/incubator-uniffle/blob/ea5a3ba45b923b1afc8fda0fdb0546daf34274fb/server/src/main/java/org/apache/uniffle/server/ShuffleServer.java#L234
   > > > 
   > > > 
   > > > I don't get your point. could you elaborate a bit more on it?
   > > 
   > > 
   > > If rpc.server.type`is`Grpc`and`netty port` is greater than 0, we should throw a exception.
   > 
   > I don't think so. If we are going to add the following constraint, users have to modify two settings to enable netty. This adds overhead to user side compared to the current way: set netty port to a non-negative one.
   
   But if it's inconsistent, it will be confusing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org