You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hutiefang76 (via GitHub)" <gi...@apache.org> on 2026/09/22 12:20:23 UTC
[PR] [python] Add SDK version to REST User-Agent [paimon]
hutiefang76 opened a new pull request, #10106:
URL: https://github.com/apache/paimon/pull/10106
## What is changed
Adds PyPaimon and Python version information to the default REST User-Agent. PVFS now uses the standard `header.User-Agent` key and adds its `PythonPVFS` prefix without replacing an explicitly configured value.
Version metadata that cannot be read or parsed falls back to `unknown`, so requests continue normally.
## Verification
- `/private/tmp/paimon-8543-venv/bin/python -m pytest pypaimon/tests/user_agent_test.py pypaimon/tests/build_info_test.py pypaimon/tests/rest/api_test.py pypaimon/tests/pvfs_oss_filesystem_test.py -q`
- `/private/tmp/paimon-8543-venv/bin/flake8 --config=dev/cfg.ini ...`
- `python -m compileall` for changed Python files
Closes #8543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add SDK version to REST User-Agent [paimon]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #10106:
URL: https://github.com/apache/paimon/pull/10106#issuecomment-5828180500
Synced with master in d61557600 to pick up the merged #10169 fix for the unrelated interval-partition CI failure. The targeted User-Agent, build-info, REST, PVFS and interval-partition tests pass locally (39 tests), and flake8 passes with the project config. The local Ray integration case was excluded because Ray is not installed. Fresh CI is now pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add SDK version to REST User-Agent [paimon]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #10106:
URL: https://github.com/apache/paimon/pull/10106#issuecomment-5843123142
Thanks for re-checking this. The upstream Python 3.12 job in run 36104552729 failed while fetching `maven-settings-builder:3.0.4`, before the tests started. I tried to rerun that failed job, but GitHub requires repository admin access. Could someone with workflow access rerun it when convenient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Preserve REST User-Agent header precedence [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #10106:
URL: https://github.com/apache/paimon/pull/10106#issuecomment-5996408345
cc @sundapeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Preserve REST User-Agent header precedence [paimon]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #10106:
URL: https://github.com/apache/paimon/pull/10106#issuecomment-6378416319
I checked [run 37044986744](https://github.com/apache/paimon/actions/runs/37044986744) for the current head `73cf38daa`: Python 3.12 completed successfully on October 2. The [job log](https://github.com/apache/paimon/actions/runs/37044986744/job/110964199526) records 6,519 passed, 223 skipped and 1,379 deselected in the main pytest invocation, with the REST/User-Agent suites executed. The overall CI run also passed, so the earlier Python 3.12 dependency-download failure is resolved.
*AI-generated update (Codex).*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add SDK version to REST User-Agent [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #10106:
URL: https://github.com/apache/paimon/pull/10106#issuecomment-5832376742
Re-reviewed head `d615576` for production. The case-insensitive User-Agent handling now preserves a lowercase caller value on the actual prepared REST request, including after catalog defaults/overrides merge; PVFS also leaves a caller-supplied header intact. This addresses my earlier P2 finding. The default header carries the SDK and Python versions, giving the linked #8543 a concrete observability benefit.
Local focused verification: 40 REST/PVFS/User-Agent tests passed; the Ray-only test was excluded because Ray is not installed here. `git diff --check` passed. Native CI and Python 3.6/3.7/3.10/3.11/3.13 passed. Python 3.12 CI failed while downloading `maven-settings-builder:3.0.4` from Maven Central (`Connection reset`), before running tests, so it needs a rerun; this is an infrastructure failure rather than a code finding. I found no remaining production blocker in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add SDK version to REST User-Agent [paimon]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #10106:
URL: https://github.com/apache/paimon/pull/10106#issuecomment-5816721649
Addressed the case-insensitive `User-Agent` feedback in `ca90868bf`. The new tests inspect the prepared HTTP request for lowercase client headers, including config merge/override behavior, and cover the PVFS option path.
The latest CI's flake8 check passes. Python Tests and Native CI still report the same two failures in `interval_partition_test.py::test_signed_zero_key_ranges_keep_versions_in_one_split` (`SimpleNamespace` lacks `path_factory`). That test file is unchanged by this PR and is identical on current `origin/master`; the PR changes only the User-Agent files. I am keeping this CI failure visible rather than treating the PR as green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org