You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2019/06/15 20:27:21 UTC

[arrow] branch master updated: ARROW-5597: [Packaging] Add Flight deb packages

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new a255f0e  ARROW-5597: [Packaging] Add Flight deb packages
a255f0e is described below

commit a255f0e7a8d35f9b875f14c6c069aa623d58d3f3
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Sun Jun 16 05:26:34 2019 +0900

    ARROW-5597: [Packaging] Add Flight deb packages
    
    Author: Sutou Kouhei <ko...@clear-code.com>
    
    Closes #4559 from kou/packaging-deb-flight and squashes the following commits:
    
    321bcc72d <Sutou Kouhei>  Add Flight deb packages
---
 cpp/cmake_modules/ThirdpartyToolchain.cmake        |  6 +++++
 dev/release/rat_exclude_files.txt                  |  2 ++
 .../linux-packages/apt/debian-stretch/Dockerfile   | 14 +++++++----
 .../linux-packages/apt/ubuntu-bionic/Dockerfile    |  3 ---
 .../linux-packages/apt/ubuntu-cosmic/Dockerfile    |  8 +++----
 dev/tasks/linux-packages/debian/control            | 28 +++++++++++++++++++---
 .../debian/libarrow-flight-dev.install             |  2 ++
 .../debian/libarrow-flight14.install               |  1 +
 .../linux-packages/debian/libgandiva-dev.install   |  1 +
 .../linux-packages/debian/libplasma-dev.install    |  1 +
 dev/tasks/linux-packages/debian/rules              | 19 ++++++++-------
 dev/tasks/tasks.yml                                | 13 ++++++++--
 12 files changed, 74 insertions(+), 24 deletions(-)

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 90c6d5e..0e37d92 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -873,6 +873,8 @@ macro(build_gflags)
                           PROPERTIES INTERFACE_LINK_LIBRARIES "shlwapi.lib")
   endif()
   set(GFLAGS_LIBRARIES ${GFLAGS_LIBRARY})
+
+  set(GFLAGS_VENDORED TRUE)
 endmacro()
 
 if(ARROW_NEED_GFLAGS)
@@ -1441,6 +1443,8 @@ macro(build_rapidjson)
 
   add_dependencies(toolchain rapidjson_ep)
   add_dependencies(rapidjson rapidjson_ep)
+
+  set(RAPIDJSON_VENDORED TRUE)
 endmacro()
 
 if(ARROW_WITH_RAPIDJSON)
@@ -1851,6 +1855,8 @@ macro(build_cares)
   set_target_properties(c-ares::cares
                         PROPERTIES IMPORTED_LOCATION "${CARES_STATIC_LIB}"
                                    INTERFACE_INCLUDE_DIRECTORIES "${CARES_INCLUDE_DIR}")
+
+  set(CARES_VENDORED TRUE)
 endmacro()
 
 if(ARROW_WITH_GRPC)
diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt
index 4438917..f8a2afd 100644
--- a/dev/release/rat_exclude_files.txt
+++ b/dev/release/rat_exclude_files.txt
@@ -95,6 +95,8 @@ dev/tasks/linux-packages/debian/libarrow-cuda-dev.install
 dev/tasks/linux-packages/debian/libarrow-cuda-glib-dev.install
 dev/tasks/linux-packages/debian/libarrow-cuda-glib14.install
 dev/tasks/linux-packages/debian/libarrow-cuda14.install
+dev/tasks/linux-packages/debian/libarrow-flight-dev.install
+dev/tasks/linux-packages/debian/libarrow-flight14.install
 dev/tasks/linux-packages/debian/libarrow-python-dev.install
 dev/tasks/linux-packages/debian/libarrow-python14.install
 dev/tasks/linux-packages/debian/libarrow14.install
diff --git a/dev/tasks/linux-packages/apt/debian-stretch/Dockerfile b/dev/tasks/linux-packages/apt/debian-stretch/Dockerfile
index 1997e8c..6d2b961 100644
--- a/dev/tasks/linux-packages/apt/debian-stretch/Dockerfile
+++ b/dev/tasks/linux-packages/apt/debian-stretch/Dockerfile
@@ -51,13 +51,12 @@ RUN \
     libboost-regex-dev \
     libboost-system-dev \
     libbrotli-dev \
+    libc-ares-dev \
     libdouble-conversion-dev \
     libgirepository1.0-dev \
     libglib2.0-doc \
     libgoogle-glog-dev \
     liblz4-dev \
-    libprotobuf-dev \
-    libprotoc-dev \
     libre2-dev \
     libsnappy-dev \
     libssl-dev \
@@ -65,15 +64,22 @@ RUN \
     lsb-release \
     ninja-build \
     pkg-config \
-    protobuf-compiler \
     python3-dev \
     python3-numpy \
+    python3-pip \
     tzdata && \
   apt install -y -V -t stretch-backports ${quiet} \
     debhelper \
+    libgmock-dev \
+    libgrpc++-dev \
     libgtest-dev \
-    meson \
+    libprotobuf-dev \
+    libprotoc-dev \
     nvidia-cuda-toolkit \
+    protobuf-compiler \
+    protobuf-compiler-grpc \
     rapidjson-dev && \
+  pip3 install --upgrade meson && \
+  ln -s /usr/local/bin/meson /usr/bin/ && \
   apt clean && \
   rm -rf /var/lib/apt/lists/*
diff --git a/dev/tasks/linux-packages/apt/ubuntu-bionic/Dockerfile b/dev/tasks/linux-packages/apt/ubuntu-bionic/Dockerfile
index 09c199f..cf40ea5 100644
--- a/dev/tasks/linux-packages/apt/ubuntu-bionic/Dockerfile
+++ b/dev/tasks/linux-packages/apt/ubuntu-bionic/Dockerfile
@@ -45,8 +45,6 @@ RUN \
     libgoogle-glog-dev \
     libgtest-dev \
     liblz4-dev \
-    libprotobuf-dev \
-    libprotoc-dev \
     libre2-dev \
     libsnappy-dev \
     libssl-dev \
@@ -55,7 +53,6 @@ RUN \
     ninja-build \
     nvidia-cuda-toolkit \
     pkg-config \
-    protobuf-compiler \
     python3-dev \
     python3-numpy \
     python3-pip \
diff --git a/dev/tasks/linux-packages/apt/ubuntu-cosmic/Dockerfile b/dev/tasks/linux-packages/apt/ubuntu-cosmic/Dockerfile
index 968a191..53eca9c 100644
--- a/dev/tasks/linux-packages/apt/ubuntu-cosmic/Dockerfile
+++ b/dev/tasks/linux-packages/apt/ubuntu-cosmic/Dockerfile
@@ -42,26 +42,26 @@ RUN \
     libdouble-conversion-dev \
     libgirepository1.0-dev \
     libglib2.0-doc \
+    libgmock-dev \
     libgoogle-glog-dev \
     libgtest-dev \
     liblz4-dev \
-    libprotobuf-dev \
-    libprotoc-dev \
     libre2-dev \
     libsnappy-dev \
     libssl-dev \
     libzstd-dev \
     lsb-release \
-    meson \
     ninja-build \
     nvidia-cuda-toolkit \
     pkg-config \
-    protobuf-compiler \
     python3-dev \
     python3-numpy \
+    python3-pip \
     rapidjson-dev \
     tzdata && \
   apt install -y -V -t cosmic-backports ${quiet} \
     debhelper && \
+  pip3 install --upgrade meson && \
+  ln -s /usr/local/bin/meson /usr/bin/ && \
   apt clean && \
   rm -rf /var/lib/apt/lists/*
diff --git a/dev/tasks/linux-packages/debian/control b/dev/tasks/linux-packages/debian/control
index a21f7b3..3febdc1 100644
--- a/dev/tasks/linux-packages/debian/control
+++ b/dev/tasks/linux-packages/debian/control
@@ -20,8 +20,6 @@ Build-Depends:
   libgoogle-glog-dev,
   libgtest-dev,
   liblz4-dev,
-  libprotobuf-dev,
-  libprotoc-dev,
   libre2-dev,
   libsnappy-dev,
   libssl-dev,
@@ -29,7 +27,6 @@ Build-Depends:
   ninja-build,
   nvidia-cuda-toolkit,
   pkg-config,
-  protobuf-compiler,
   python3-dev,
   python3-numpy,
   tzdata
@@ -77,6 +74,19 @@ Description: Apache Arrow is a data processing library for analysis
  .
  This package provides C++ library files for CUDA support.
 
+Package: libarrow-flight14
+Section: libs
+Architecture: any
+Multi-Arch: same
+Pre-Depends: ${misc:Pre-Depends}
+Depends:
+  ${misc:Depends},
+  ${shlibs:Depends},
+  libarrow14 (= ${binary:Version})
+Description: Apache Arrow is a data processing library for analysis
+ .
+ This package provides C++ library files for Flight RPC system.
+
 Package: libarrow-dev
 Section: libdevel
 Architecture: any
@@ -112,6 +122,18 @@ Description: Apache Arrow is a data processing library for analysis
  .
  This package provides C++ header files for CUDA support.
 
+Package: libarrow-flight-dev
+Section: libdevel
+Architecture: any
+Multi-Arch: same
+Depends:
+  ${misc:Depends},
+  libarrow-dev (= ${binary:Version}),
+  libarrow-flight14 (= ${binary:Version})
+Description: Apache Arrow is a data processing library for analysis
+ .
+ This package provides C++ header files for Flight RPC system.
+
 Package: libgandiva14
 Section: libs
 Architecture: any
diff --git a/dev/tasks/linux-packages/debian/libarrow-flight-dev.install b/dev/tasks/linux-packages/debian/libarrow-flight-dev.install
new file mode 100644
index 0000000..d7f56d7
--- /dev/null
+++ b/dev/tasks/linux-packages/debian/libarrow-flight-dev.install
@@ -0,0 +1,2 @@
+usr/lib/*/libarrow_flight.a
+usr/lib/*/libarrow_flight.so
diff --git a/dev/tasks/linux-packages/debian/libarrow-flight14.install b/dev/tasks/linux-packages/debian/libarrow-flight14.install
new file mode 100644
index 0000000..abdb96d
--- /dev/null
+++ b/dev/tasks/linux-packages/debian/libarrow-flight14.install
@@ -0,0 +1 @@
+usr/lib/*/libarrow_flight.so.*
diff --git a/dev/tasks/linux-packages/debian/libgandiva-dev.install b/dev/tasks/linux-packages/debian/libgandiva-dev.install
index 1e5d264..835e0ac 100644
--- a/dev/tasks/linux-packages/debian/libgandiva-dev.install
+++ b/dev/tasks/linux-packages/debian/libgandiva-dev.install
@@ -1,3 +1,4 @@
+usr/include/gandiva/
 usr/lib/*/libgandiva.a
 usr/lib/*/libgandiva.so
 usr/lib/*/pkgconfig/gandiva.pc
diff --git a/dev/tasks/linux-packages/debian/libplasma-dev.install b/dev/tasks/linux-packages/debian/libplasma-dev.install
index d3538d2..fc5904e 100644
--- a/dev/tasks/linux-packages/debian/libplasma-dev.install
+++ b/dev/tasks/linux-packages/debian/libplasma-dev.install
@@ -1,3 +1,4 @@
+usr/include/plasma/
 usr/lib/*/libplasma.a
 usr/lib/*/libplasma.so
 usr/lib/*/pkgconfig/plasma.pc
diff --git a/dev/tasks/linux-packages/debian/rules b/dev/tasks/linux-packages/debian/rules
index 6bc91ba..efb0c55 100755
--- a/dev/tasks/linux-packages/debian/rules
+++ b/dev/tasks/linux-packages/debian/rules
@@ -19,8 +19,9 @@ override_dh_auto_configure:
 	  --builddirectory=cpp_build \
 	  --buildsystem=cmake+ninja \
 	  -- \
-	  -DARROW_BUILD_TESTS=ON \
+	  -DARROW_BUILD_TESTS=OFF \
 	  -DARROW_CUDA=ON \
+	  -DARROW_FLIGHT=ON \
 	  -DARROW_GANDIVA=ON \
 	  -DARROW_GANDIVA_JAVA=OFF \
 	  -DARROW_ORC=ON \
@@ -61,10 +62,12 @@ override_dh_auto_install:
 	  --buildsystem=meson+ninja
 
 override_dh_auto_test:
-	git clone --depth 1 https://github.com/apache/arrow-testing.git
-	git clone --depth 1 https://github.com/apache/parquet-testing.git
-	cd cpp_build &&								\
-	  env									\
-	    ARROW_TEST_DATA=$(CURDIR)/arrow-testing/data			\
-	    PARQUET_TEST_DATA=$(CURDIR)/parquet-testing/data			\
-	      ctest --exclude-regex 'arrow-cuda-test|plasma-client_tests'
+	# TODO: We need Boost 1.64 or later to build tests for
+	# Apache Arrow Flight.
+	# git clone --depth 1 https://github.com/apache/arrow-testing.git
+	# git clone --depth 1 https://github.com/apache/parquet-testing.git
+	# cd cpp_build &&								\
+	#   env									\
+	#     ARROW_TEST_DATA=$(CURDIR)/arrow-testing/data			\
+	#     PARQUET_TEST_DATA=$(CURDIR)/parquet-testing/data			\
+	#       ctest --exclude-regex 'arrow-cuda-test|plasma-client_tests'
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 6e89a55..3e3acff 100644
--- a/dev/tasks/tasks.yml
+++ b/dev/tasks/tasks.yml
@@ -287,6 +287,9 @@ tasks:
       - libarrow-cuda-glib14_{no_rc_version}-1_amd64.deb
       - libarrow-cuda14-dbgsym_{no_rc_version}-1_amd64.deb
       - libarrow-cuda14_{no_rc_version}-1_amd64.deb
+      - libarrow-flight-dev_{no_rc_version}-1_amd64.deb
+      - libarrow-flight14-dbgsym_{no_rc_version}-1_amd64.deb
+      - libarrow-flight14_{no_rc_version}-1_amd64.deb
       - libarrow-python-dev_{no_rc_version}-1_amd64.deb
       - libarrow-python14-dbgsym_{no_rc_version}-1_amd64.deb
       - libarrow-python14_{no_rc_version}-1_amd64.deb
@@ -368,7 +371,7 @@ tasks:
     platform: linux
     template: linux-packages/travis.linux.yml
     params:
-      build_command: rake apt:build APT_TARGETS=ubuntu-bionic
+      build_command: travis_wait 45 rake apt:build APT_TARGETS=ubuntu-bionic
       upload_extensions:
         - .deb
         - .dsc
@@ -391,6 +394,9 @@ tasks:
       - libarrow-cuda-glib-dev_{no_rc_version}-1_amd64.deb
       - libarrow-cuda-glib14_{no_rc_version}-1_amd64.deb
       - libarrow-cuda14_{no_rc_version}-1_amd64.deb
+      - libarrow-flight-dev_{no_rc_version}-1_amd64.deb
+      - libarrow-flight14-dbgsym_{no_rc_version}-1_amd64.deb
+      - libarrow-flight14_{no_rc_version}-1_amd64.deb
       - libarrow-python-dev_{no_rc_version}-1_amd64.deb
       - libarrow-python14_{no_rc_version}-1_amd64.deb
       - libarrow14_{no_rc_version}-1_amd64.deb
@@ -416,7 +422,7 @@ tasks:
     platform: linux
     template: linux-packages/travis.linux.yml
     params:
-      build_command: rake apt:build APT_TARGETS=ubuntu-cosmic
+      build_command: travis_wait 45 rake apt:build APT_TARGETS=ubuntu-cosmic
       upload_extensions:
         - .deb
         - .dsc
@@ -439,6 +445,9 @@ tasks:
       - libarrow-cuda-glib-dev_{no_rc_version}-1_amd64.deb
       - libarrow-cuda-glib14_{no_rc_version}-1_amd64.deb
       - libarrow-cuda14_{no_rc_version}-1_amd64.deb
+      - libarrow-flight-dev_{no_rc_version}-1_amd64.deb
+      - libarrow-flight14-dbgsym_{no_rc_version}-1_amd64.deb
+      - libarrow-flight14_{no_rc_version}-1_amd64.deb
       - libarrow-python-dev_{no_rc_version}-1_amd64.deb
       - libarrow-python14_{no_rc_version}-1_amd64.deb
       - libarrow14_{no_rc_version}-1_amd64.deb