You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by Nicola Baiocco <ni...@intesys.it> on 2015/05/20 11:01:08 UTC

Null ids in SyncJob report

Hi,

we are using Syncope 1.2.4, but I saw the same behavior in earlier versions, at the first syncronization with AD the SyncJob Report is like this:

Users [created/failures]: 6/1 [updated/failures]: 0/0 [deleted/failures]: 0/0 [ignored]: 0
Roles [created/failures]: 5/0 [updated/failures]: 0/0 [deleted/failures]: 0/0 [ignored]: 0

Users failed to create: CREATE FAILURE (id/name): null/utente4 with message: SyncopeClientCompositeException: {[RequiredValuesMissing [surname, email]]}

Users created:
CREATE SUCCESS (id/name): null/user4me2
CREATE SUCCESS (id/name): null/user4me5
CREATE SUCCESS (id/name): null/user4me8
CREATE SUCCESS (id/name): null/user.4me7
CREATE SUCCESS (id/name): null/user.4me42015012702
CREATE SUCCESS (id/name): null/User4me2015012606

Users updated:

Users deleted:

Users ignored:

Roles created:
CREATE SUCCESS (id/name): 250/SyncopeTest
CREATE SUCCESS (id/name): null/LDAPSync4Me2
CREATE SUCCESS (id/name): 252/LDAPSync4Me3
CREATE SUCCESS (id/name): null/TestSync4Me1
CREATE SUCCESS (id/name): 254/TestSyncGroup4Me
Roles updated:

Roles deleted:

Roles ignored:

Some Ids are null and some not, is it correct?

Kind regards.

[http://www.intesys.it/firme/logo_intesys.jpg]
Nicola Baiocco | Software Developer
Intesys - Via Roveggia 122 A - 37136 Verona
Tel. 045 503663 | Fax 045 503604
nicola.baiocco@intesys.it
www.intesys.it<http://www.intesys.it>
[Lavoro Sicuro]
Le informazioni contenute nella presente e-mail e nei suoi allegati potrebbero essere confidenziali/riservate e sono dirette unicamente ai destinatari sopra indicati. In caso di ricezione da parte di persona diversa è vietato qualunque tipo di divulgazione o copia anche parziale. Chi riceva questo messaggio per errore è pregato di inoltrarlo al mittente e di cancellare questa e-mail.
This e-mail and its attachments may contain confidential/reserved information and is intended only for the use of the address(es) named above. If the reader of this message is not the intended recipient of this message, please note that distribution or copying of this communication is forbidden. Anyone who receives this communication in error should return it immediately to the sender and delete the message.

R: R: Null ids in SyncJob report

Posted by Nicola Baiocco <ni...@intesys.it>.
Ok

Nicola Baiocco | Software Developer

Intesys - Via Roveggia 122 A  - 37136 Verona
Tel. 045 503663 | Fax 045 503604
nicola.baiocco@intesys.it
www.intesys.it

Le informazioni contenute nella presente e-mail e nei suoi allegati potrebbero essere confidenziali/riservate e sono dirette unicamente ai destinatari sopra indicati. In caso di ricezione da parte di persona diversa ? vietato qualunque tipo di divulgazione o copia anche parziale. Chi riceva questo messaggio per errore ? pregato di inoltrarlo al mittente e di cancellare questa e-mail.

This e-mail and its attachments may contain confidential/reserved information and is intended only for the use of the address(es) named above. If the reader of this message is not the intended recipient of this message, please note that distribution or copying of this communication is forbidden. Anyone who receives this communication in error should return it immediately to the sender and delete the message. 

-----Messaggio originale-----
Da: Fabio Martelli [mailto:fabio.martelli@gmail.com] 
Inviato: martedì 26 maggio 2015 17:44
A: dev@syncope.apache.org
Oggetto: Re: R: Null ids in SyncJob report

Il 26/05/2015 15:57, Nicola Baiocco ha scritto:
> Hi Fabio,
>
> after more tests :) i've more details :)
>
> Our scenario:
> Syncope synchronizes from AD e propagates to an external custom resource (all this process is done by a SyncTask).
>
> If during the user/role propagation, to external resource, an exception is thrown the id will be null in report.
>
> In my opinion, after saw UserSyncResultHandler.doCreate, the cause  could be that
> 	result.setId(created.getResult().getKey());
> is placed after
> 	taskExecutor.execute(tasks);
>
> that in my case can throw an RuntimeException.
>
> Hopes this will clarify my last message.
Hi Nicola, probably you are right.
Can you open a new issue providing a patch (check it in your env)?

Thank you in advance.
Best regards,
F.
>
> Kind regards.
>
> Nicola Baiocco | Software Developer
>
> Intesys - Via Roveggia 122 A  - 37136 Verona Tel. 045 503663 | Fax 045 
> 503604 nicola.baiocco@intesys.it www.intesys.it
>
> Le informazioni contenute nella presente e-mail e nei suoi allegati potrebbero essere confidenziali/riservate e sono dirette unicamente ai destinatari sopra indicati. In caso di ricezione da parte di persona diversa ? vietato qualunque tipo di divulgazione o copia anche parziale. Chi riceva questo messaggio per errore ? pregato di inoltrarlo al mittente e di cancellare questa e-mail.
>
> This e-mail and its attachments may contain confidential/reserved information and is intended only for the use of the address(es) named above. If the reader of this message is not the intended recipient of this message, please note that distribution or copying of this communication is forbidden. Anyone who receives this communication in error should return it immediately to the sender and delete the message.
>
> -----Messaggio originale-----
> Da: Fabio Martelli [mailto:fabio.martelli@gmail.com]
> Inviato: lunedì 25 maggio 2015 13:03
> A: dev@syncope.apache.org
> Oggetto: Re: Null ids in SyncJob report
>
>
> Il 20/05/2015 11:01, Nicola Baiocco ha scritto:
>> Hi,
>>
>> we are using Syncope 1.2.4, but I saw the same behavior in earlier 
>> versions, at the first syncronization with AD the SyncJob Report is 
>> like this:
>>
>> Users [created/failures]: 6/1 [updated/failures]: 0/0
>> [deleted/failures]: 0/0 [ignored]: 0
>>
>> Roles [created/failures]: 5/0 [updated/failures]: 0/0
>> [deleted/failures]: 0/0 [ignored]: 0
>>
>> Users failed to create: CREATE FAILURE (id/name): null/utente4 with
>> message: SyncopeClientCompositeException: {[RequiredValuesMissing 
>> [surname, email]]}
>>
>> Users created:
>>
>> CREATE SUCCESS (id/name): null/user4me2
>>
>> CREATE SUCCESS (id/name): null/user4me5
>>
>> CREATE SUCCESS (id/name): null/user4me8
>>
>> CREATE SUCCESS (id/name): null/user.4me7
>>
>> CREATE SUCCESS (id/name): null/user.4me42015012702
>>
>> CREATE SUCCESS (id/name): null/User4me2015012606
>>
>> Users updated:
>>
>> Users deleted:
>>
>> Users ignored:
>>
>> Roles created:
>>
>> CREATE SUCCESS (id/name): 250/SyncopeTest
>>
>> CREATE SUCCESS (id/name): null/LDAPSync4Me2
>>
>> CREATE SUCCESS (id/name): 252/LDAPSync4Me3
>>
>> CREATE SUCCESS (id/name): null/TestSync4Me1
>>
>> CREATE SUCCESS (id/name): 254/TestSyncGroup4Me
>>
>> Roles updated:
>>
>> Roles deleted:
>>
>> Roles ignored:
>>
>> Some Ids are null and some not, is it correct?
>>
> Hi Nicola, absolutely not correct: it shouldn't never happen.
> I checked the code again and it seems correct.
>
> I'm not able to reproduce this strange behavior: can you provide more details about your env?
>
> Kind regards,
> F.
>
>> Kind regards.
>>
>> http://www.intesys.it/firme/logo_intesys.jpg
>>
>> *Nicola Baiocco**| Software Developer*
>>
>> Intesys - Via Roveggia 122 A - 37136 Verona Tel. 045 503663 | Fax 045
>> 503604 nicola.baiocco@intesys.it www.intesys.it 
>> <http://www.intesys.it>
>>
>> Lavoro Sicuro
>>
>> /Le informazioni contenute nella presente e-mail e nei suoi allegati 
>> potrebbero essere confidenziali/riservate e sono dirette unicamente 
>> ai destinatari sopra indicati. In caso di ricezione da parte di 
>> persona diversa è vietato qualunque tipo di divulgazione o copia 
>> anche parziale. Chi riceva questo messaggio per errore è pregato di 
>> inoltrarlo al mittente e di cancellare questa e-mail. /
>>
>> /This e-mail and its attachments may contain confidential/reserved 
>> information and is intended only for the use of the address(es) named 
>> above. If the reader of this message is not the intended recipient of 
>> this message, please note that distribution or copying of this 
>> communication is forbidden. Anyone who receives this communication in 
>> error should return it immediately to the sender and delete the 
>> message. /
>>
>
> --
> Fabio Martelli
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Apache Syncope PMC
> http://people.apache.org/~fmartelli/
>


--
Fabio Martelli

Tirasa - Open Source Excellence
http://www.tirasa.net/

Apache Syncope PMC
http://people.apache.org/~fmartelli/


Re: R: Null ids in SyncJob report

Posted by Fabio Martelli <fa...@gmail.com>.
Il 26/05/2015 15:57, Nicola Baiocco ha scritto:
> Hi Fabio,
>
> after more tests :) i've more details :)
>
> Our scenario:
> Syncope synchronizes from AD e propagates to an external custom resource (all this process is done by a SyncTask).
>
> If during the user/role propagation, to external resource, an exception is thrown the id will be null in report.
>
> In my opinion, after saw UserSyncResultHandler.doCreate, the cause  could be that
> 	result.setId(created.getResult().getKey());
> is placed after
> 	taskExecutor.execute(tasks);
>
> that in my case can throw an RuntimeException.
>
> Hopes this will clarify my last message.
Hi Nicola, probably you are right.
Can you open a new issue providing a patch (check it in your env)?

Thank you in advance.
Best regards,
F.
>
> Kind regards.
>
> Nicola Baiocco | Software Developer
>
> Intesys - Via Roveggia 122 A  - 37136 Verona
> Tel. 045 503663 | Fax 045 503604
> nicola.baiocco@intesys.it
> www.intesys.it
>
> Le informazioni contenute nella presente e-mail e nei suoi allegati potrebbero essere confidenziali/riservate e sono dirette unicamente ai destinatari sopra indicati. In caso di ricezione da parte di persona diversa ? vietato qualunque tipo di divulgazione o copia anche parziale. Chi riceva questo messaggio per errore ? pregato di inoltrarlo al mittente e di cancellare questa e-mail.
>
> This e-mail and its attachments may contain confidential/reserved information and is intended only for the use of the address(es) named above. If the reader of this message is not the intended recipient of this message, please note that distribution or copying of this communication is forbidden. Anyone who receives this communication in error should return it immediately to the sender and delete the message.
>
> -----Messaggio originale-----
> Da: Fabio Martelli [mailto:fabio.martelli@gmail.com]
> Inviato: lunedì 25 maggio 2015 13:03
> A: dev@syncope.apache.org
> Oggetto: Re: Null ids in SyncJob report
>
>
> Il 20/05/2015 11:01, Nicola Baiocco ha scritto:
>> Hi,
>>
>> we are using Syncope 1.2.4, but I saw the same behavior in earlier
>> versions, at the first syncronization with AD the SyncJob Report is
>> like this:
>>
>> Users [created/failures]: 6/1 [updated/failures]: 0/0
>> [deleted/failures]: 0/0 [ignored]: 0
>>
>> Roles [created/failures]: 5/0 [updated/failures]: 0/0
>> [deleted/failures]: 0/0 [ignored]: 0
>>
>> Users failed to create: CREATE FAILURE (id/name): null/utente4 with
>> message: SyncopeClientCompositeException: {[RequiredValuesMissing
>> [surname, email]]}
>>
>> Users created:
>>
>> CREATE SUCCESS (id/name): null/user4me2
>>
>> CREATE SUCCESS (id/name): null/user4me5
>>
>> CREATE SUCCESS (id/name): null/user4me8
>>
>> CREATE SUCCESS (id/name): null/user.4me7
>>
>> CREATE SUCCESS (id/name): null/user.4me42015012702
>>
>> CREATE SUCCESS (id/name): null/User4me2015012606
>>
>> Users updated:
>>
>> Users deleted:
>>
>> Users ignored:
>>
>> Roles created:
>>
>> CREATE SUCCESS (id/name): 250/SyncopeTest
>>
>> CREATE SUCCESS (id/name): null/LDAPSync4Me2
>>
>> CREATE SUCCESS (id/name): 252/LDAPSync4Me3
>>
>> CREATE SUCCESS (id/name): null/TestSync4Me1
>>
>> CREATE SUCCESS (id/name): 254/TestSyncGroup4Me
>>
>> Roles updated:
>>
>> Roles deleted:
>>
>> Roles ignored:
>>
>> Some Ids are null and some not, is it correct?
>>
> Hi Nicola, absolutely not correct: it shouldn't never happen.
> I checked the code again and it seems correct.
>
> I'm not able to reproduce this strange behavior: can you provide more details about your env?
>
> Kind regards,
> F.
>
>> Kind regards.
>>
>> http://www.intesys.it/firme/logo_intesys.jpg
>>
>> *Nicola Baiocco**| Software Developer*
>>
>> Intesys - Via Roveggia 122 A - 37136 Verona Tel. 045 503663 | Fax 045
>> 503604 nicola.baiocco@intesys.it www.intesys.it
>> <http://www.intesys.it>
>>
>> Lavoro Sicuro
>>
>> /Le informazioni contenute nella presente e-mail e nei suoi allegati
>> potrebbero essere confidenziali/riservate e sono dirette unicamente ai
>> destinatari sopra indicati. In caso di ricezione da parte di persona
>> diversa è vietato qualunque tipo di divulgazione o copia anche
>> parziale. Chi riceva questo messaggio per errore è pregato di
>> inoltrarlo al mittente e di cancellare questa e-mail. /
>>
>> /This e-mail and its attachments may contain confidential/reserved
>> information and is intended only for the use of the address(es) named
>> above. If the reader of this message is not the intended recipient of
>> this message, please note that distribution or copying of this
>> communication is forbidden. Anyone who receives this communication in
>> error should return it immediately to the sender and delete the
>> message. /
>>
>
> --
> Fabio Martelli
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Apache Syncope PMC
> http://people.apache.org/~fmartelli/
>


-- 
Fabio Martelli

Tirasa - Open Source Excellence
http://www.tirasa.net/

Apache Syncope PMC
http://people.apache.org/~fmartelli/


R: Null ids in SyncJob report

Posted by Nicola Baiocco <ni...@intesys.it>.
Hi Fabio,

after more tests :) i've more details :)

Our scenario:
Syncope synchronizes from AD e propagates to an external custom resource (all this process is done by a SyncTask).

If during the user/role propagation, to external resource, an exception is thrown the id will be null in report.

In my opinion, after saw UserSyncResultHandler.doCreate, the cause  could be that 
	result.setId(created.getResult().getKey());
is placed after 
	taskExecutor.execute(tasks);

that in my case can throw an RuntimeException.

Hopes this will clarify my last message.

Kind regards.

Nicola Baiocco | Software Developer

Intesys - Via Roveggia 122 A  - 37136 Verona
Tel. 045 503663 | Fax 045 503604
nicola.baiocco@intesys.it
www.intesys.it

Le informazioni contenute nella presente e-mail e nei suoi allegati potrebbero essere confidenziali/riservate e sono dirette unicamente ai destinatari sopra indicati. In caso di ricezione da parte di persona diversa ? vietato qualunque tipo di divulgazione o copia anche parziale. Chi riceva questo messaggio per errore ? pregato di inoltrarlo al mittente e di cancellare questa e-mail.

This e-mail and its attachments may contain confidential/reserved information and is intended only for the use of the address(es) named above. If the reader of this message is not the intended recipient of this message, please note that distribution or copying of this communication is forbidden. Anyone who receives this communication in error should return it immediately to the sender and delete the message. 

-----Messaggio originale-----
Da: Fabio Martelli [mailto:fabio.martelli@gmail.com] 
Inviato: lunedì 25 maggio 2015 13:03
A: dev@syncope.apache.org
Oggetto: Re: Null ids in SyncJob report


Il 20/05/2015 11:01, Nicola Baiocco ha scritto:
>
> Hi,
>
> we are using Syncope 1.2.4, but I saw the same behavior in earlier 
> versions, at the first syncronization with AD the SyncJob Report is 
> like this:
>
> Users [created/failures]: 6/1 [updated/failures]: 0/0
> [deleted/failures]: 0/0 [ignored]: 0
>
> Roles [created/failures]: 5/0 [updated/failures]: 0/0
> [deleted/failures]: 0/0 [ignored]: 0
>
> Users failed to create: CREATE FAILURE (id/name): null/utente4 with
> message: SyncopeClientCompositeException: {[RequiredValuesMissing 
> [surname, email]]}
>
> Users created:
>
> CREATE SUCCESS (id/name): null/user4me2
>
> CREATE SUCCESS (id/name): null/user4me5
>
> CREATE SUCCESS (id/name): null/user4me8
>
> CREATE SUCCESS (id/name): null/user.4me7
>
> CREATE SUCCESS (id/name): null/user.4me42015012702
>
> CREATE SUCCESS (id/name): null/User4me2015012606
>
> Users updated:
>
> Users deleted:
>
> Users ignored:
>
> Roles created:
>
> CREATE SUCCESS (id/name): 250/SyncopeTest
>
> CREATE SUCCESS (id/name): null/LDAPSync4Me2
>
> CREATE SUCCESS (id/name): 252/LDAPSync4Me3
>
> CREATE SUCCESS (id/name): null/TestSync4Me1
>
> CREATE SUCCESS (id/name): 254/TestSyncGroup4Me
>
> Roles updated:
>
> Roles deleted:
>
> Roles ignored:
>
> Some Ids are null and some not, is it correct?
>

Hi Nicola, absolutely not correct: it shouldn't never happen.
I checked the code again and it seems correct.

I'm not able to reproduce this strange behavior: can you provide more details about your env?

Kind regards,
F.

> Kind regards.
>
> http://www.intesys.it/firme/logo_intesys.jpg
>
> *Nicola Baiocco**| Software Developer*
>
> Intesys - Via Roveggia 122 A - 37136 Verona Tel. 045 503663 | Fax 045 
> 503604 nicola.baiocco@intesys.it www.intesys.it 
> <http://www.intesys.it>
>
> Lavoro Sicuro
>
> /Le informazioni contenute nella presente e-mail e nei suoi allegati 
> potrebbero essere confidenziali/riservate e sono dirette unicamente ai 
> destinatari sopra indicati. In caso di ricezione da parte di persona 
> diversa è vietato qualunque tipo di divulgazione o copia anche 
> parziale. Chi riceva questo messaggio per errore è pregato di 
> inoltrarlo al mittente e di cancellare questa e-mail. /
>
> /This e-mail and its attachments may contain confidential/reserved 
> information and is intended only for the use of the address(es) named 
> above. If the reader of this message is not the intended recipient of 
> this message, please note that distribution or copying of this 
> communication is forbidden. Anyone who receives this communication in 
> error should return it immediately to the sender and delete the 
> message. /
>


--
Fabio Martelli

Tirasa - Open Source Excellence
http://www.tirasa.net/

Apache Syncope PMC
http://people.apache.org/~fmartelli/


Re: Null ids in SyncJob report

Posted by Fabio Martelli <fa...@gmail.com>.
Il 20/05/2015 11:01, Nicola Baiocco ha scritto:
>
> Hi,
>
> we are using Syncope 1.2.4, but I saw the same behavior in earlier 
> versions, at the first syncronization with AD the SyncJob Report is 
> like this:
>
> Users [created/failures]: 6/1 [updated/failures]: 0/0 
> [deleted/failures]: 0/0 [ignored]: 0
>
> Roles [created/failures]: 5/0 [updated/failures]: 0/0 
> [deleted/failures]: 0/0 [ignored]: 0
>
> Users failed to create: CREATE FAILURE (id/name): null/utente4 with 
> message: SyncopeClientCompositeException: {[RequiredValuesMissing 
> [surname, email]]}
>
> Users created:
>
> CREATE SUCCESS (id/name): null/user4me2
>
> CREATE SUCCESS (id/name): null/user4me5
>
> CREATE SUCCESS (id/name): null/user4me8
>
> CREATE SUCCESS (id/name): null/user.4me7
>
> CREATE SUCCESS (id/name): null/user.4me42015012702
>
> CREATE SUCCESS (id/name): null/User4me2015012606
>
> Users updated:
>
> Users deleted:
>
> Users ignored:
>
> Roles created:
>
> CREATE SUCCESS (id/name): 250/SyncopeTest
>
> CREATE SUCCESS (id/name): null/LDAPSync4Me2
>
> CREATE SUCCESS (id/name): 252/LDAPSync4Me3
>
> CREATE SUCCESS (id/name): null/TestSync4Me1
>
> CREATE SUCCESS (id/name): 254/TestSyncGroup4Me
>
> Roles updated:
>
> Roles deleted:
>
> Roles ignored:
>
> Some Ids are null and some not, is it correct?
>

Hi Nicola, absolutely not correct: it shouldn't never happen.
I checked the code again and it seems correct.

I'm not able to reproduce this strange behavior: can you provide more 
details about your env?

Kind regards,
F.

> Kind regards.
>
> http://www.intesys.it/firme/logo_intesys.jpg
>
> *Nicola Baiocco**| Software Developer*
>
> Intesys - Via Roveggia 122 A - 37136 Verona
> Tel. 045 503663 | Fax 045 503604
> nicola.baiocco@intesys.it
> www.intesys.it <http://www.intesys.it>
>
> Lavoro Sicuro
>
> /Le informazioni contenute nella presente e-mail e nei suoi allegati 
> potrebbero essere confidenziali/riservate e sono dirette unicamente ai 
> destinatari sopra indicati. In caso di ricezione da parte di persona 
> diversa è vietato qualunque tipo di divulgazione o copia anche 
> parziale. Chi riceva questo messaggio per errore è pregato di 
> inoltrarlo al mittente e di cancellare questa e-mail. /
>
> /This e-mail and its attachments may contain confidential/reserved 
> information and is intended only for the use of the address(es) named 
> above. If the reader of this message is not the intended recipient of 
> this message, please note that distribution or copying of this 
> communication is forbidden. Anyone who receives this communication in 
> error should return it immediately to the sender and delete the message. /
>


-- 
Fabio Martelli

Tirasa - Open Source Excellence
http://www.tirasa.net/

Apache Syncope PMC
http://people.apache.org/~fmartelli/