[GitHub] [apisix-ingress-controller] aynp commented on a diff in pull request #1460: make: dev-env

["aynp (via GitHub)" <gi...@apache.org>]

aynp commented on code in PR #1460:
URL: https://github.com/apache/apisix-ingress-controller/pull/1460#discussion_r1161343050


##########
Makefile:
##########
@@ -325,3 +324,19 @@ install-gateway-api-local:
 .PHONY: uninstall-gateway-api
 uninstall-gateway-api:
 	kubectl delete -f $(GATEWAY_API_CRDS_LOCAL_PATH)
+
+### dev-env:			  Launch development environment
+.PHONY: dev-env
+dev-env: kind-up pack-image
+	helm repo add apisix https://charts.apiseven.com
+	helm repo update
+	helm install apisix apisix/apisix \
+		--set gateway.type=NodePort \
+		--set ingress-controller.enabled=true \
+		--namespace ingress-apisix \
+		--create-namespace
+	kubectl set image deployment/apisix-ingress-controller ingress-controller=$(REGISTRY)/apache/apisix-ingress-controller:dev --namespace ingress-apisix
+

Review Comment:
   I guess newer versions of helm automatically detect if the repository exists and skips over without throwing any error. 
   Also if errors are to be handled, maybe it would be cleaner to be a script file just like `kind-up`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org