You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Quintin Beukes (JIRA)" <ji...@apache.org> on 2009/10/12 15:39:31 UTC
[jira] Created: (GERONIMO-4903) Jetty Advanced Integration Test
Failure
Jetty Advanced Integration Test Failure
---------------------------------------
Key: GERONIMO-4903
URL: https://issues.apache.org/jira/browse/GERONIMO-4903
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: connector
Reporter: Quintin Beukes
Fix For: 2.2
Attachments: jetty-advanced-test-failure.patch
Hey,
I found the cause of the test failure.
In the file: {src
root}/plugins/jetty7/geronimo-jetty7/./src/main/java/org/apache/geronimo/jetty7/connector/JettyConnector.java
Line: 289
It reads: new String[]{"host", "port", "minThreads", "maxThreads",
"bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
"lingerMillis", "protocol", "redirectPort", "connectUrl",
"maxIdleTimeMs"},
Change to: new String[]{"host", "port", "minThreads", "maxThreads",
"bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
"lingerMillis", "redirectPort", "maxIdleTimeMs"},
Basically removing the "protocol" and "connectUrl" attributes from the
persistent interface attributes fixes the problem.
"protocol" is static for Jetty BIO connector, so it doesn't need to be
saved, or can't be specified.
"connectUrl" is generated on the fly through getConnectUrl(), so can't
be saved either.
So unless my understanding of what persistentAttributes are is
incorrect, this seems to be the correct solution? Please correct me if
I'm wrong.
What caused the problem is that the JettyConnector class doesn't have
a setter for these attributes, so when XBean searches all the
specified attributes' setters, it fails when it can't find these. This
caused the test to fail, because the connector doesn't start again
after being edited (enters the failed state).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4903) Jetty Advanced Integration Test
Failure
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved GERONIMO-4903.
------------------------------------
Resolution: Fixed
> Jetty Advanced Integration Test Failure
> ---------------------------------------
>
> Key: GERONIMO-4903
> URL: https://issues.apache.org/jira/browse/GERONIMO-4903
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: connector
> Affects Versions: 2.2
> Reporter: Quintin Beukes
> Assignee: Donald Woods
> Fix For: 2.2, 3.0
>
> Attachments: jetty-advanced-test-failure.patch
>
>
> Hey,
> I found the cause of the test failure.
> In the file: {src
> root}/plugins/jetty7/geronimo-jetty7/./src/main/java/org/apache/geronimo/jetty7/connector/JettyConnector.java
> Line: 289
> It reads: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "protocol", "redirectPort", "connectUrl",
> "maxIdleTimeMs"},
> Change to: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "redirectPort", "maxIdleTimeMs"},
> Basically removing the "protocol" and "connectUrl" attributes from the
> persistent interface attributes fixes the problem.
> "protocol" is static for Jetty BIO connector, so it doesn't need to be
> saved, or can't be specified.
> "connectUrl" is generated on the fly through getConnectUrl(), so can't
> be saved either.
> So unless my understanding of what persistentAttributes are is
> incorrect, this seems to be the correct solution? Please correct me if
> I'm wrong.
> What caused the problem is that the JettyConnector class doesn't have
> a setter for these attributes, so when XBean searches all the
> specified attributes' setters, it fails when it can't find these. This
> caused the test to fail, because the connector doesn't start again
> after being edited (enters the failed state).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4903) Jetty Advanced Integration Test
Failure
Posted by "Quintin Beukes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765961#action_12765961 ]
Quintin Beukes commented on GERONIMO-4903:
------------------------------------------
If GERONIMO-4907 is applied, it could become an option to revert revision #824389 and #824390.
> Jetty Advanced Integration Test Failure
> ---------------------------------------
>
> Key: GERONIMO-4903
> URL: https://issues.apache.org/jira/browse/GERONIMO-4903
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: connector
> Affects Versions: 2.2
> Reporter: Quintin Beukes
> Assignee: Donald Woods
> Fix For: 2.2, 3.0
>
> Attachments: jetty-advanced-test-failure.patch
>
>
> Hey,
> I found the cause of the test failure.
> In the file: {src
> root}/plugins/jetty7/geronimo-jetty7/./src/main/java/org/apache/geronimo/jetty7/connector/JettyConnector.java
> Line: 289
> It reads: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "protocol", "redirectPort", "connectUrl",
> "maxIdleTimeMs"},
> Change to: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "redirectPort", "maxIdleTimeMs"},
> Basically removing the "protocol" and "connectUrl" attributes from the
> persistent interface attributes fixes the problem.
> "protocol" is static for Jetty BIO connector, so it doesn't need to be
> saved, or can't be specified.
> "connectUrl" is generated on the fly through getConnectUrl(), so can't
> be saved either.
> So unless my understanding of what persistentAttributes are is
> incorrect, this seems to be the correct solution? Please correct me if
> I'm wrong.
> What caused the problem is that the JettyConnector class doesn't have
> a setter for these attributes, so when XBean searches all the
> specified attributes' setters, it fails when it can't find these. This
> caused the test to fail, because the connector doesn't start again
> after being edited (enters the failed state).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4903) Jetty Advanced Integration Test
Failure
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated GERONIMO-4903:
-----------------------------------
Affects Version/s: 2.2
Fix Version/s: 3.0
Assignee: Donald Woods
> Jetty Advanced Integration Test Failure
> ---------------------------------------
>
> Key: GERONIMO-4903
> URL: https://issues.apache.org/jira/browse/GERONIMO-4903
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: connector
> Affects Versions: 2.2
> Reporter: Quintin Beukes
> Assignee: Donald Woods
> Fix For: 2.2, 3.0
>
> Attachments: jetty-advanced-test-failure.patch
>
>
> Hey,
> I found the cause of the test failure.
> In the file: {src
> root}/plugins/jetty7/geronimo-jetty7/./src/main/java/org/apache/geronimo/jetty7/connector/JettyConnector.java
> Line: 289
> It reads: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "protocol", "redirectPort", "connectUrl",
> "maxIdleTimeMs"},
> Change to: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "redirectPort", "maxIdleTimeMs"},
> Basically removing the "protocol" and "connectUrl" attributes from the
> persistent interface attributes fixes the problem.
> "protocol" is static for Jetty BIO connector, so it doesn't need to be
> saved, or can't be specified.
> "connectUrl" is generated on the fly through getConnectUrl(), so can't
> be saved either.
> So unless my understanding of what persistentAttributes are is
> incorrect, this seems to be the correct solution? Please correct me if
> I'm wrong.
> What caused the problem is that the JettyConnector class doesn't have
> a setter for these attributes, so when XBean searches all the
> specified attributes' setters, it fails when it can't find these. This
> caused the test to fail, because the connector doesn't start again
> after being edited (enters the failed state).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4903) Jetty Advanced Integration Test
Failure
Posted by "Quintin Beukes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Quintin Beukes updated GERONIMO-4903:
-------------------------------------
Attachment: jetty-advanced-test-failure.patch
attached the patch to fix the issue
> Jetty Advanced Integration Test Failure
> ---------------------------------------
>
> Key: GERONIMO-4903
> URL: https://issues.apache.org/jira/browse/GERONIMO-4903
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: connector
> Reporter: Quintin Beukes
> Fix For: 2.2
>
> Attachments: jetty-advanced-test-failure.patch
>
>
> Hey,
> I found the cause of the test failure.
> In the file: {src
> root}/plugins/jetty7/geronimo-jetty7/./src/main/java/org/apache/geronimo/jetty7/connector/JettyConnector.java
> Line: 289
> It reads: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "protocol", "redirectPort", "connectUrl",
> "maxIdleTimeMs"},
> Change to: new String[]{"host", "port", "minThreads", "maxThreads",
> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize",
> "lingerMillis", "redirectPort", "maxIdleTimeMs"},
> Basically removing the "protocol" and "connectUrl" attributes from the
> persistent interface attributes fixes the problem.
> "protocol" is static for Jetty BIO connector, so it doesn't need to be
> saved, or can't be specified.
> "connectUrl" is generated on the fly through getConnectUrl(), so can't
> be saved either.
> So unless my understanding of what persistentAttributes are is
> incorrect, this seems to be the correct solution? Please correct me if
> I'm wrong.
> What caused the problem is that the JettyConnector class doesn't have
> a setter for these attributes, so when XBean searches all the
> specified attributes' setters, it fails when it can't find these. This
> caused the test to fail, because the connector doesn't start again
> after being edited (enters the failed state).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.