You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "hxzd5568 (via GitHub)" <gi...@apache.org> on 2023/03/15 12:38:45 UTC
[GitHub] [tvm] hxzd5568 opened a new pull request, #14306: Add a data type check for TVMArrayCopyFromTo
hxzd5568 opened a new pull request, #14306:
URL: https://github.com/apache/tvm/pull/14306
Add a data type check for tvm.nd.array's API TVMArrayCopyFromTo. Lacking the type check
leads to a value error in some situations.
For example, the user input x to a builded graph, the x has a shape of [200,10] and has a dtype of 'float32'. When copying the x
to the NDarray placeholder with type 'float64' whose shape is [100,10], the program doesn't report a warning, because it can pass the size check i.e. 200*10*32==100*10*64, however, every 64 continous bits in inputx is treated a number and copyed to the new ndarray, the values change. because of different hardcode. More importantly, this kind of error is implict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hxzd5568 closed pull request #14306: Add a data type check for TVMArrayCopyFromTo
Posted by "hxzd5568 (via GitHub)" <gi...@apache.org>.
hxzd5568 closed pull request #14306: Add a data type check for TVMArrayCopyFromTo
URL: https://github.com/apache/tvm/pull/14306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14306: Add a data type check for TVMArrayCopyFromTo
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14306:
URL: https://github.com/apache/tvm/pull/14306#issuecomment-1469930163
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org