You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2013/11/05 20:34:31 UTC
[jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Should **not** be merged until after #9.
This will have to be merged and rebased after #9 is done, but I'm pretty sure the validation that is currently _broken_ was actually intended.
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-labs-google fix-project-name-validation
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/12
-- Commit Summary --
* Enforcing identity format '...@developer.gserviceaccount.com' correctly
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceExpectTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/BaseGoogleComputeEngineApiExpectTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/BaseGoogleComputeEngineExpectTest.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/12.patch
https://github.com/jclouds/jclouds-labs-google/pull/12.diff
Re: [jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Posted by Andrew Phillips <no...@github.com>.
@abayer: Based on [this comment](https://github.com/jclouds/jclouds-labs-google/pull/9/files#r7448227), any thoughts on whether this restriction should actually be enforced..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/12#issuecomment-27819785
Re: [jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-google #483](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/483/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/12#issuecomment-27923272
Re: [jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Posted by Andrew Phillips <no...@github.com>.
Dropping following comments by @abayer and in the [related PR](https://github.com/jclouds/jclouds-labs-google/pull/9#discussion_r7443403).
The parsing will not break or do "weird things" if the `@project.gserviceaccount.com` suffix is missing, so the check is not really needed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/12#issuecomment-28088137
Re: [jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #18](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/18/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/12#issuecomment-27923123
Re: [jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Posted by Andrew Bayer <no...@github.com>.
@demobox - yeah, I'd tend not to favor enforcing it - they could go all weird and change around their format again for all we know. But I don't feel strongly one way or the other.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/12#issuecomment-27923447
Re: [jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #16](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/16/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/12#issuecomment-27804747
Re: [jclouds-labs-google] Enforcing identity format
'...@developer.gserviceaccount.com' correctly (#12)
Posted by Andrew Phillips <no...@github.com>.
> @demobox - yeah, I'd tend not to favor enforcing it - they could go all weird and change around their format again
> for all we know. But I don't feel strongly one way or the other.
Fine with dropping this, then. But then the original code (which made [an invalid attempt to enforce this](https://github.com/jclouds/jclouds-labs-google/blob/5ec13c95bdaa64baf22ea7178785df1b7fb14ea0/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java#L104)) was broken, or..?
In other words, we're OK with effectively _dropping_ any requirement on the identity format?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/12#issuecomment-27933023