You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/11/30 18:38:20 UTC

[GitHub] [echarts] scttcper opened a new issue #16146: [Bug] Echarts tooltip throttle getWidth error

scttcper opened a new issue #16146:
URL: https://github.com/apache/echarts/issues/16146


   ### Version
   
   5.2.2
   
   ### Link to minimal reproduction
   
   _No response_
   
   ### Steps To Reproduce
   
   Destroy a component while the tooltip is recalculating position, the throttle function attempts to run after the chart has been destroyed.
   
   
   ![image](https://user-images.githubusercontent.com/1400464/144106293-e1e62fe5-3382-406a-8ff7-693e1eea824b.png)
   
   ```
   TypeError: this._zr is null
     at getWidth(../node_modules/echarts/lib/core/echarts.js:447:5)
     at apply(../node_modules/echarts/lib/component/tooltip/TooltipView.js:647:31)
     at exec(../node_modules/echarts/lib/util/throttle.js:72:8)
   ```
   
   ### Current Behavior
   
   getWidth errors
   
   ### Expected Behavior
   
   The throttle function should be destroyed when the chart is destroyed, or getWidth should fail silently
   
   I believe this is not being destroyed https://github.com/apache/echarts/blob/6641951e1bd1bb7beb18a695caaa39a5fda0e885/src/component/tooltip/TooltipView.ts#L229
   
   
   ### Environment
   
   ```markdown
   - OS: MacOs
   - Browser: chrome 96
   - Framework: react
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on issue #16146: [Bug] Echarts tooltip throttle getWidth error

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #16146:
URL: https://github.com/apache/echarts/issues/16146#issuecomment-983198306


   Thanks for the feedback. It has been fixed in https://github.com/apache/echarts/pull/16070. Which will be included in our next version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] scttcper commented on issue #16146: [Bug] Echarts tooltip throttle getWidth error

Posted by GitBox <gi...@apache.org>.
scttcper commented on issue #16146:
URL: https://github.com/apache/echarts/issues/16146#issuecomment-983225507


   @pissang cheers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] scttcper closed issue #16146: [Bug] Echarts tooltip throttle getWidth error

Posted by GitBox <gi...@apache.org>.
scttcper closed issue #16146:
URL: https://github.com/apache/echarts/issues/16146


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org