You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2011/07/20 03:54:58 UTC

[jira] [Created] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
-----------------------------------------------------------------------------------------------------------------------------------------

                 Key: TAP5-1580
                 URL: https://issues.apache.org/jira/browse/TAP5-1580
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3
            Reporter: Howard M. Lewis Ship
            Priority: Critical


Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068155#comment-13068155 ] 

Hudson commented on TAP5-1580:
------------------------------

Integrated in tapestry-trunk-freestyle #424 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/424/])
    TAP5-1580: A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
Roll version number back to alpha-5, due to problem with TAP5-1580 fix

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148606
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148605
Files : 
* /tapestry/tapestry5/trunk/build.gradle


> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1580.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

Too two tries to fix it!

> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068129#comment-13068129 ] 

Hudson commented on TAP5-1580:
------------------------------

Integrated in tapestry-trunk-freestyle #423 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/423/])
    TAP5-1580: A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148599
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java


> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1580.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

Too two tries to fix it!

> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1580:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068155#comment-13068155 ] 

Hudson commented on TAP5-1580:
------------------------------

Integrated in tapestry-trunk-freestyle #424 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/424/])
    TAP5-1580: A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
Roll version number back to alpha-5, due to problem with TAP5-1580 fix

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148606
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148605
Files : 
* /tapestry/tapestry5/trunk/build.gradle


> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068129#comment-13068129 ] 

Hudson commented on TAP5-1580:
------------------------------

Integrated in tapestry-trunk-freestyle #423 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/423/])
    TAP5-1580: A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148599
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java


> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070719#comment-13070719 ] 

Hudson commented on TAP5-1580:
------------------------------

Integrated in tapestry-trunk-freestyle #435 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/435/])
    TAP5-1580: Provide more logging information about pruned pages
TAP5-1580: Mark additional constants as deprecated

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150818
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageSourceImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/SkinningTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/pageload/ComponentResourceSelectorTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150813
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TransformConstants.java


> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1580:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1580) A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070719#comment-13070719 ] 

Hudson commented on TAP5-1580:
------------------------------

Integrated in tapestry-trunk-freestyle #435 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/435/])
    TAP5-1580: Provide more logging information about pruned pages
TAP5-1580: Mark additional constants as deprecated

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150818
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageSourceImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/SkinningTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/pageload/ComponentResourceSelectorTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150813
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TransformConstants.java


> A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1580
>                 URL: https://issues.apache.org/jira/browse/TAP5-1580
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Critical
>             Fix For: 5.3
>
>
> Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed.  Probably do the first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira