You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@beehive.apache.org by Carlin Rogers <ca...@gmail.com> on 2005/08/26 01:32:41 UTC

[PATCH] BEEHIVE-822: ScopedServletUtils.getOuterRequest()...

I've attached a patch that can be used for testing/verifying the
earlier fix/patch
to BEEHIVE-882. The test case runs in mock portal. The page flow running in
the mock portlet calls ScopedServletUtils.getOuterRequest(request) and then
sets an attribute on the outer request. The main JSP then tries to print that
request attribute (outside of the scope of the page flow portlet). 

With the initial bug, the attribute would not appear on the outer request
and the JSP would print null. Now the attribute appears.

For now the test case must be run manually because testRecorder does not
support multipart requests, "multipart/form-data". See BEEHIVE-483.

Note this patch is only a manual test so should be fine to add for V1.

Regards,
Carlin

Re: [PATCH] BEEHIVE-822: ScopedServletUtils.getOuterRequest()...

Posted by Rich Feit <ri...@gmail.com>.

Hi Carlin,

Thanks for the additional test -- I submitted it earlier tonight.  It's 
great to have some coverage (even manual coverage at this point) of the 
multipart functionality.

Rich

Carlin Rogers wrote:

>I've attached a patch that can be used for testing/verifying the
>earlier fix/patch
>to BEEHIVE-882. The test case runs in mock portal. The page flow running in
>the mock portlet calls ScopedServletUtils.getOuterRequest(request) and then
>sets an attribute on the outer request. The main JSP then tries to print that
>request attribute (outside of the scope of the page flow portlet). 
>
>With the initial bug, the attribute would not appear on the outer request
>and the JSP would print null. Now the attribute appears.
>
>For now the test case must be run manually because testRecorder does not
>support multipart requests, "multipart/form-data". See BEEHIVE-483.
>
>Note this patch is only a manual test so should be fine to add for V1.
>
>Regards,
>Carlin
>
>  
>

Re: [PATCH] BEEHIVE-822: ScopedServletUtils.getOuterRequest()...

Posted by Carlin Rogers <ca...@gmail.com>.

Note, the patch is actually attached to the JIRA issue. Thanks.

On 8/25/05, Carlin Rogers <ca...@gmail.com> wrote:
> I've attached a patch that can be used for testing/verifying the
> earlier fix/patch
> to BEEHIVE-882. The test case runs in mock portal. The page flow running in
> the mock portlet calls ScopedServletUtils.getOuterRequest(request) and then
> sets an attribute on the outer request. The main JSP then tries to print that
> request attribute (outside of the scope of the page flow portlet).
> 
> With the initial bug, the attribute would not appear on the outer request
> and the JSP would print null. Now the attribute appears.
> 
> For now the test case must be run manually because testRecorder does not
> support multipart requests, "multipart/form-data". See BEEHIVE-483.
> 
> Note this patch is only a manual test so should be fine to add for V1.
> 
> Regards,
> Carlin
>