You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/13 16:08:50 UTC
[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #83: Fix constructions of sed filter in corner cases
ams-tschoening commented on a change in pull request #83:
URL: https://github.com/apache/logging-log4cxx/pull/83#discussion_r767901515
##########
File path: src/test/cpp/util/transformer.cpp
##########
@@ -116,14 +116,25 @@ void Transformer::createSedCommandFile(const std::string& regexName,
std::string tmp;
+ auto sedsaniziter = [] (const std::string in, const std::string sedseperator = "Q") {
Review comment:
Shouldn't the arguments better be `const std::string&`? Especially as you are copying `in` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org