You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/01 18:32:45 UTC

[GitHub] dpogue opened a new pull request #448: Fix unit tests against cordova-common master (next major)

dpogue opened a new pull request #448: Fix unit tests against cordova-common master (next major)
URL: https://github.com/apache/cordova-ios/pull/448
 
 
   **Note:** This can't be merged until we do a release of cordova-common next major and update the dependency in cordova-ios package.json. But I'm opening this now so it's ready to go whenever that process happens.
   
   ### Platforms affected
   iOS, but it's unit testing so technically none
   
   ### What does this PR do?
   Fixes the unit tests when run against cordova-common master (which uses `fs-extra`)
   
   ### What testing has been done on this change?
   Unit tests now pass.
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org