[GitHub] [superset] zhaoyongjie edited a comment on pull request #15734: chore: Add tags to gallery(iteration 1)

[GitBox <gi...@apache.org>]

zhaoyongjie edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881408917


   > Hey @zhaoyongjie. Thanks for the PR.
   > 
   > I think we should not set `Popular` as default. When opening the modal with an existing viz type, only the footer is showing the right type information now. I would expect to see the selected viz type and related category as well.
   > 
   > <img alt="Screen Shot 2021-07-16 at 14 01 09" width="1133" src="https://user-images.githubusercontent.com/60598000/125944665-d8855b68-680b-49c1-b9a1-8e85b99d7464.png">
   
   Hi, @geido. This behavior is by product design. please check here https://github.com/apache/superset/projects/30
   I also wonder, why there is a chart here without the `popular` tag. 
   
   If this change is approved by @junlincc. I will continue to tweak the search logic.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org