You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Erik van Oosten (JIRA)" <ji...@apache.org> on 2009/12/08 15:01:20 UTC

[jira] Created: (WICKET-2600) Redirect to home page still does not work (regression)

Redirect to home page still does not work (regression)
------------------------------------------------------

                 Key: WICKET-2600
                 URL: https://issues.apache.org/jira/browse/WICKET-2600
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.4, 1.3.7, 1.5-M1
            Reporter: Erik van Oosten


It is still not possible to redirect to the home under all circumstances with Tomcat + IE (6, 7 and 8).

WICKET-847 fixed a problem by removing any "./" at the start of the redirect URL.
WICKET-1916 undid this for redirect URLs that are exactly equal to "./".

The latter fix is not correct, IE can not redirect to "./".
The correct addition to WICKET-847 would be to redirect to ".". See patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-2600) Redirect to home page still does not work (regression)

Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787981#action_12787981 ] 

Erik van Oosten edited comment on WICKET-2600 at 12/9/09 9:10 AM:
------------------------------------------------------------------

Yes, I tested this with Firefox 3.5 (Ubuntu), Chrome 3.0 (Windows), and IE 5.5, 6, 7 and 8.

BTW, it is within reason that any other browser that understands "./" will also understand ".". Under this assumption the patch can make the situation only better, not worse.

      was (Author: erikvanoosten):
    Yes, I tested this with Firefox 3.5 (Ubuntu), Chrome 3.0 (Windows), and IE 5.5, 6, 7 and 8.

BTW, it is within reason that any other browser that understands "./" will also understand ".".
  
> Redirect to home page still does not work (regression)
> ------------------------------------------------------
>
>                 Key: WICKET-2600
>                 URL: https://issues.apache.org/jira/browse/WICKET-2600
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.7, 1.4.4, 1.5-M1
>            Reporter: Erik van Oosten
>         Attachments: WICKET-2600.patch
>
>
> It is still not possible to redirect to the home under all circumstances with Tomcat + IE (6, 7 and 8).
> WICKET-847 fixed a problem by removing any "./" at the start of the redirect URL.
> WICKET-1916 undid this for redirect URLs that are exactly equal to "./".
> The latter fix is not correct, IE can not redirect to "./".
> The correct addition to WICKET-847 would be to redirect to ".". See patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2600) Redirect to home page still does not work (regression)

Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787981#action_12787981 ] 

Erik van Oosten commented on WICKET-2600:
-----------------------------------------

Yes, I tested this with Firefox 3.5 (Ubuntu), Chrome 3.0 (Windows), and IE 5.5, 6, 7 and 8.

BTW, it is within reason that any other browser that understands "./" will also understand ".".

> Redirect to home page still does not work (regression)
> ------------------------------------------------------
>
>                 Key: WICKET-2600
>                 URL: https://issues.apache.org/jira/browse/WICKET-2600
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.7, 1.4.4, 1.5-M1
>            Reporter: Erik van Oosten
>         Attachments: WICKET-2600.patch
>
>
> It is still not possible to redirect to the home under all circumstances with Tomcat + IE (6, 7 and 8).
> WICKET-847 fixed a problem by removing any "./" at the start of the redirect URL.
> WICKET-1916 undid this for redirect URLs that are exactly equal to "./".
> The latter fix is not correct, IE can not redirect to "./".
> The correct addition to WICKET-847 would be to redirect to ".". See patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2600) Redirect to home page still does not work (regression)

Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik van Oosten updated WICKET-2600:
------------------------------------

    Attachment: WICKET-2600.patch

Patch can be applied in:
- trunk
- branch 1.4.x
- branch 1.3.x


> Redirect to home page still does not work (regression)
> ------------------------------------------------------
>
>                 Key: WICKET-2600
>                 URL: https://issues.apache.org/jira/browse/WICKET-2600
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.7, 1.4.4, 1.5-M1
>            Reporter: Erik van Oosten
>         Attachments: WICKET-2600.patch
>
>
> It is still not possible to redirect to the home under all circumstances with Tomcat + IE (6, 7 and 8).
> WICKET-847 fixed a problem by removing any "./" at the start of the redirect URL.
> WICKET-1916 undid this for redirect URLs that are exactly equal to "./".
> The latter fix is not correct, IE can not redirect to "./".
> The correct addition to WICKET-847 would be to redirect to ".". See patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2600) Redirect to home page still does not work (regression)

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787921#action_12787921 ] 

Igor Vaynberg commented on WICKET-2600:
---------------------------------------

have you tested that this works with firefox and chrome?

> Redirect to home page still does not work (regression)
> ------------------------------------------------------
>
>                 Key: WICKET-2600
>                 URL: https://issues.apache.org/jira/browse/WICKET-2600
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.7, 1.4.4, 1.5-M1
>            Reporter: Erik van Oosten
>         Attachments: WICKET-2600.patch
>
>
> It is still not possible to redirect to the home under all circumstances with Tomcat + IE (6, 7 and 8).
> WICKET-847 fixed a problem by removing any "./" at the start of the redirect URL.
> WICKET-1916 undid this for redirect URLs that are exactly equal to "./".
> The latter fix is not correct, IE can not redirect to "./".
> The correct addition to WICKET-847 would be to redirect to ".". See patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2600) Redirect to home page still does not work (regression)

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2600.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M1
                   1.4.5
         Assignee: Igor Vaynberg

> Redirect to home page still does not work (regression)
> ------------------------------------------------------
>
>                 Key: WICKET-2600
>                 URL: https://issues.apache.org/jira/browse/WICKET-2600
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.7, 1.4.4, 1.5-M1
>            Reporter: Erik van Oosten
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.5, 1.5-M1
>
>         Attachments: WICKET-2600.patch
>
>
> It is still not possible to redirect to the home under all circumstances with Tomcat + IE (6, 7 and 8).
> WICKET-847 fixed a problem by removing any "./" at the start of the redirect URL.
> WICKET-1916 undid this for redirect URLs that are exactly equal to "./".
> The latter fix is not correct, IE can not redirect to "./".
> The correct addition to WICKET-847 would be to redirect to ".". See patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.