You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Sachin Goel (JIRA)" <ji...@apache.org> on 2015/08/01 18:14:04 UTC

[jira] [Comment Edited] (FLINK-2459) Failure on recently added Client side logging test

    [ https://issues.apache.org/jira/browse/FLINK-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650419#comment-14650419 ] 

Sachin Goel edited comment on FLINK-2459 at 8/1/15 4:13 PM:
------------------------------------------------------------

Yes, by itself checking that the flag is passed is easy. However, [~mxm] asked to write a test where it is provably true that there are no log outputs on the console. 
[When I first created the PR, I hadn't actually even written a test case to verify that the flag was passed, which I think doesn't actually need to be verified separately. It just rolls in with all the other run options.]
I do have a fix I'm testing right now. I'll have to trigger the build at least 3-4 times since the failure is not too often.


was (Author: sachingoel0101):
Yes, by itself checking that the flag is passed is easy. However, [~mxm] asked to write a test where it is provably true that there are no log outputs on the console. 
[When I first created the PR, I hadn't actually even written a test case to verify that the flag was passed, which I think doesn't actually need to be verified separately. It just rolls in with all the other run options.]
I do have a fix I'm testing right now. I'll have the trigger the build at least 3-4 times since the failure is not too often.

> Failure on recently added Client side logging test
> --------------------------------------------------
>
>                 Key: FLINK-2459
>                 URL: https://issues.apache.org/jira/browse/FLINK-2459
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> A recent commit (authored by me) added a flag on CliFrontend to disable sysout logging on console. The unit test for this fails sporadically because of unavailable port while starting the cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)