[GitHub] [airflow] dstandish commented on a change in pull request #19307: Check next run exists before reading data interval

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #19307:
URL: https://github.com/apache/airflow/pull/19307#discussion_r739605390



##########
File path: tests/models/test_dag.py
##########
@@ -2234,3 +2234,40 @@ def next_dagrun_info(self, last_automated_data_interval, restriction):
         ),
     ]
     assert caplog.records[0].exc_info is not None, "should contain exception context"
+
+
+@pytest.mark.parametrize(
+    "logical_date, data_interval_start, data_interval_end, expected_data_interval",
+    [
+        pytest.param(None, None, None, None, id="no-next-run"),
+        pytest.param(
+            DEFAULT_DATE,
+            DEFAULT_DATE,
+            DEFAULT_DATE + timedelta(days=1),

Review comment:
       for modern, your explicit data interval and the schedule interval are both 1 day.  so it's sortof ambiguous what's driving the result.  seems it might be better to choose an interval that differs from the schedule interval of the dag, to make it really clear what drives the result




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org