You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2024/07/23 21:54:23 UTC
[PR] GH-43396: [Java] Remove/replace jsr305 [arrow]
laurentgo opened a new pull request, #43397:
URL: https://github.com/apache/arrow/pull/43397
### Rationale for this change
jsr305 is not maintained anymore and is unlikely to support JPMS. The classes are also in the javax. namespace which is known to cause issues as well.
### What changes are included in this PR?
Replace most uses of jsr305 with the equivalent checker framework annotations, and remove usage of `@ThreadSafe.`
### Are these changes tested?
CI/CD
### Are there any user-facing changes?
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43396: [Java] Remove/replace jsr305 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #43397:
URL: https://github.com/apache/arrow/pull/43397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43396: [Java] Remove/replace jsr305 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #43397:
URL: https://github.com/apache/arrow/pull/43397#issuecomment-2251302340
> I thought Protobuf generated code depended on this at some point but apparently not anymore.
Turns out this line omits the annotation that protobuf was adding: https://github.com/apache/arrow/pull/43139/files#diff-d8225ebcfc11b480a6e4f54e183b67c3ead51635a167c106d928c2abf1f9ef66R492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43396: [Java] Remove/replace jsr305 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43397:
URL: https://github.com/apache/arrow/pull/43397#issuecomment-2246408869
Revision: d2f5bb824f2e67b7e81d8e536cfc119cfcc14729
Submitted crossbow builds: [ursacomputing/crossbow @ actions-86dce0d4ec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-86dce0d4ec)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/10067192923/job/27830183973)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/10067192916/job/27830183101)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10067192992/job/27830183468)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10067192912/job/27830182934)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10067192926/job/27830182944)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10067192910/job/27830182973)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10067192915/job/27830182954)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43396: [Java] Remove/replace jsr305 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43397:
URL: https://github.com/apache/arrow/pull/43397#issuecomment-2246381149
:warning: GitHub issue #43396 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43396: [Java] Remove/replace jsr305 [arrow]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #43397:
URL: https://github.com/apache/arrow/pull/43397#issuecomment-2246406753
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43396: [Java] Remove/replace jsr305 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43397:
URL: https://github.com/apache/arrow/pull/43397#issuecomment-2247835916
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4835a3cec8f1420e9515cfabdd757126574c9342.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/27858498654) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org