You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/28 15:44:26 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5099: arch/sim: Implement up_backtrace

xiaoxiang781216 opened a new pull request #5099:
URL: https://github.com/apache/incubator-nuttx/pull/5099


   ## Summary
   Support backtrace on simulator
   
   ## Impact
   sim
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao merged pull request #5099: arch/sim: Implement up_backtrace

Posted by GitBox <gi...@apache.org>.
anchao merged pull request #5099:
URL: https://github.com/apache/incubator-nuttx/pull/5099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] normanr commented on pull request #5099: arch/sim: Implement up_backtrace

Posted by GitBox <gi...@apache.org>.
normanr commented on pull request #5099:
URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002624146


   It works great, and with only 15% overhead! (480K --> 550K)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5099: arch/sim: Implement up_backtrace

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5099:
URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002609532


   risc-v is already supported by @anchao , you just need add up_backtrace.c into CMN_CSRS and turn on the option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] normanr commented on pull request #5099: arch/sim: Implement up_backtrace

Posted by GitBox <gi...@apache.org>.
normanr commented on pull request #5099:
URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002606551


   very nice, are there plans to support this for risc-v too? It looks like it's only missing the `CMN_CSRCS` condition in the `Make.defs` files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] normanr commented on pull request #5099: arch/sim: Implement up_backtrace

Posted by GitBox <gi...@apache.org>.
normanr commented on pull request #5099:
URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002621229


   I'm not sure if bl602 has enough space for `ALLSYMS`, but I managed to get backtrace working by adding
   ```
   ifeq ($(CONFIG_SCHED_BACKTRACE),y)
   CMN_CSRCS += riscv_backtrace.c
   endif
   ```
   to `arch/risc-v/src/bl602/Make.defs`: https://gist.github.com/lupyuen/ccfd90125f9a180b4cfb459e8a57b323#gistcomment-4010689


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5099: arch/sim: Implement up_backtrace

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #5099:
URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002609532


   risc-v is already supported by @anchao , you just need add up_backtrace.c into CMN_CSRS and turn on the option: https://github.com/apache/incubator-nuttx/pull/5057.
   You may like these patch too: https://github.com/apache/incubator-nuttx/pull/4962 and https://github.com/apache/incubator-nuttx/pull/5098/commits/f57dacab60b532a69421550d1e5d8d32ce43e853.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org