[GitHub] [lucene-solr] PuneethBikkumanla commented on pull request #1858: LUCENE-6744: equals methods should compare classes directly, not use instanceof

[GitBox <gi...@apache.org>]

PuneethBikkumanla commented on pull request #1858:
URL: https://github.com/apache/lucene-solr/pull/1858#issuecomment-692813025


   > Are there any tests that can be added to show how instanceOf fails or inferior?
   
   I will look to add tests. I actually traced through the code currently testing these classes, but there didn't seem to be any tests testing them individually. I'll look into how I can add tests into the existing framework or add new test classes to test this behavior.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org