You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/12/09 23:22:16 UTC
Review Request 28875: Added remove-executor hook for slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/#review66822
-----------------------------------------------------------
See comments to prior RR's.
src/hook/manager.hpp
<https://reviews.apache.org/r/28875/#comment110475>
How about using Try<Nothing> instead?
- Niklas Nielsen
On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28875/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2015, 2:42 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-2060
> https://issues.apache.org/jira/browse/MESOS-2060
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is different from decorators in the sense that it doesn't return anything.
>
>
> Diffs
> -----
>
> src/hook/hook.hpp PRE-CREATION
> src/hook/manager.hpp PRE-CREATION
> src/hook/manager.cpp PRE-CREATION
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
>
> Diff: https://reviews.apache.org/r/28875/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 8:05 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
minor fixes.
Bugs: MESOS-2060
https://issues.apache.org/jira/browse/MESOS-2060
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs (updated)
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 7:46 p.m.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2060
https://issues.apache.org/jira/browse/MESOS-2060
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs (updated)
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 7:36 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Addressed Nik's comments.
Bugs: MESOS-2060
https://issues.apache.org/jira/browse/MESOS-2060
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs (updated)
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/#review67962
-----------------------------------------------------------
Ship it!
Modulo API comment
- Niklas Nielsen
On Jan. 13, 2015, 10:25 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28875/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 10:25 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-2060
> https://issues.apache.org/jira/browse/MESOS-2060
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is different from decorators in the sense that it doesn't return anything.
>
>
> Diffs
> -----
>
> src/hook/hook.hpp PRE-CREATION
> src/hook/manager.hpp PRE-CREATION
> src/hook/manager.cpp PRE-CREATION
> src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
>
> Diff: https://reviews.apache.org/r/28875/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 1:25 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
addressed nik's comments.
Bugs: MESOS-2060
https://issues.apache.org/jira/browse/MESOS-2060
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs (updated)
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Jan. 5, 2015, 5:49 p.m., Timothy Chen wrote:
> > src/hook/manager.cpp, line 124
> > <https://reviews.apache.org/r/28875/diff/3/?file=803964#file803964line124>
> >
> > This should never happen right? CHECK instead?
This can happen, if non of the hook modules install a remove-executor hook. This is true for other hooks as well.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/#review66741
-----------------------------------------------------------
On Jan. 5, 2015, 5:42 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28875/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-2060
> https://issues.apache.org/jira/browse/MESOS-2060
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is different from decorators in the sense that it doesn't return anything.
>
>
> Diffs
> -----
>
> src/hook/hook.hpp PRE-CREATION
> src/hook/manager.hpp PRE-CREATION
> src/hook/manager.cpp PRE-CREATION
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
>
> Diff: https://reviews.apache.org/r/28875/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/#review66741
-----------------------------------------------------------
src/hook/manager.cpp
<https://reviews.apache.org/r/28875/#comment110344>
This should never happen right? CHECK instead?
- Timothy Chen
On Jan. 5, 2015, 10:42 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28875/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2015, 10:42 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-2060
> https://issues.apache.org/jira/browse/MESOS-2060
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is different from decorators in the sense that it doesn't return anything.
>
>
> Diffs
> -----
>
> src/hook/hook.hpp PRE-CREATION
> src/hook/manager.hpp PRE-CREATION
> src/hook/manager.cpp PRE-CREATION
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
>
> Diff: https://reviews.apache.org/r/28875/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
(Updated Jan. 5, 2015, 5:42 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Added jira ticket.
Bugs: MESOS-2060
https://issues.apache.org/jira/browse/MESOS-2060
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 6:57 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs (updated)
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
-----------------------------------------------------------
(Updated Dec. 9, 2014, 6:45 p.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
This is different from decorators in the sense that it doesn't return anything.
Diffs (updated)
-----
src/hook/hook.hpp PRE-CREATION
src/hook/manager.hpp PRE-CREATION
src/hook/manager.cpp PRE-CREATION
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
Diff: https://reviews.apache.org/r/28875/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 28875: Added remove-executor hook for slave.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/#review64458
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28655, 28656, 28875]
All tests passed.
- Mesos ReviewBot
On Dec. 9, 2014, 10:22 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28875/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 10:22 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is different from decorators in the sense that it doesn't return anything.
>
>
> Diffs
> -----
>
> src/hook/hook.hpp PRE-CREATION
> src/hook/manager.hpp PRE-CREATION
> src/hook/manager.cpp PRE-CREATION
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
>
> Diff: https://reviews.apache.org/r/28875/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>