[GitHub] [sling-org-apache-sling-security] klcodanr commented on a diff in pull request #9: SLING-9061 - Adding support for evaluating the origin as well as the referrer and pluggable referrer configurations

["klcodanr (via GitHub)" <gi...@apache.org>]

klcodanr commented on code in PR #9:
URL: https://github.com/apache/sling-org-apache-sling-security/pull/9#discussion_r1194572478


##########
src/main/java/org/apache/sling/security/impl/ReferrerFilter.java:
##########
@@ -260,16 +264,32 @@ private Pattern[] createRegexPatterns(final String[] regexps) {
         return patterns.toArray(new Pattern[0]);
     }
 
+    private String[] mergeValues(String[] primary, List<ReferrerFilterAmendment> amendments,

Review Comment:
   Honestly, minimizing changes, but collections are fine or needed 4/5 times so it makes sense to change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org