You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/17 13:40:22 UTC
[GitHub] [arrow] raulcd opened a new pull request, #14664: MINOR: [Release] Add RC number and version to verify release candidate success message
raulcd opened a new pull request, #14664:
URL: https://github.com/apache/arrow/pull/14664
I've tested locally when verifying 10.0.1 rc 0:
```
Release candidate number: 0 for version: 10.0.1 looks good!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14664: MINOR: [Release] Add RC number and version to verify release candidate success message
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14664:
URL: https://github.com/apache/arrow/pull/14664#issuecomment-1325669076
Merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14664: MINOR: [Release] Add RC number and version to verify release candidate success message
Posted by GitBox <gi...@apache.org>.
kou merged PR #14664:
URL: https://github.com/apache/arrow/pull/14664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14664: MINOR: [Release] Add RC number and version to verify release candidate success message
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14664:
URL: https://github.com/apache/arrow/pull/14664#issuecomment-1327942595
Benchmark runs are scheduled for baseline = fb29effbb689014ea50f8bf3814539d5cc8f7021 and contender = ada7e23959dabcd4f586ad8c269dc2a6267ccacd. ada7e23959dabcd4f586ad8c269dc2a6267ccacd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e59f19d07a654cfeb3a3eb8e64ec9205...a53586a5f194411aa1724ac9ac0e78b3/)
[Finished :arrow_down:0.44% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/022d4a12abab4b9faea8cbeff885f9ed...6875a6fc68b14beeba574a0987563a52/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f5d7249860334b36ae3d82a9e7a33830...be83531a336746c9b31dcea0240bb2db/)
[Finished :arrow_down:0.24% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/df266cae366f4a308f40f4ddd2769f4c...dd8a78b1b0a149418b002e009a6948f2/)
Buildkite builds:
[Finished] [`ada7e239` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1925)
[Finished] [`ada7e239` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1947)
[Finished] [`ada7e239` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1917)
[Finished] [`ada7e239` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1939)
[Finished] [`fb29effb` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1924)
[Finished] [`fb29effb` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1946)
[Finished] [`fb29effb` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1916)
[Finished] [`fb29effb` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1938)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14664: MINOR: [Release] Add RC number and version to verify release candidate success message
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14664:
URL: https://github.com/apache/arrow/pull/14664#discussion_r1025605908
##########
dev/release/verify-release-candidate.sh:
##########
@@ -1198,5 +1198,5 @@ test_binary_distribution
TEST_SUCCESS=yes
-echo 'Release candidate looks good!'
+echo "Release candidate number: ${RC_NUMBER} for version: ${VERSION} looks good!"
Review Comment:
It's not a strong opinion but how about simplifying it?
```suggestion
echo "Release candidate ${VERSION}-RC${RC_NUMBER} looks good!"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #14664: MINOR: [Release] Add RC number and version to verify release candidate success message
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #14664:
URL: https://github.com/apache/arrow/pull/14664#issuecomment-1325179862
@kou I think this can be merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org