You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/11/16 14:53:35 UTC
[PR] fix(trait): use a configmap index [camel-k]
squakez opened a new pull request, #5948:
URL: https://github.com/apache/camel-k/pull/5948
Closes #5924
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(trait): use a configmap index
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): use a configmap index [camel-k]
Posted by "hernanDatgDev (via GitHub)" <gi...@apache.org>.
hernanDatgDev commented on PR #5948:
URL: https://github.com/apache/camel-k/pull/5948#issuecomment-2486642070
@squakez Yes you're right there is some additional validation on the openapi spec and it expects certain parts to be present. I made the necessary changes and got the expected behavior. I also got the expected behavior with the original files I provided in my ticket. The changes made seem good to me so far 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): use a configmap index [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5948:
URL: https://github.com/apache/camel-k/pull/5948#issuecomment-2486361884
It could be caused by the removal of a swagger validator [1] or even the upgrade of swagger dependencies which may be adding now some validation to avoid such value to be empty.
https://camel.apache.org/manual/camel-4x-upgrade-guide-4_6.html#_camel_rest_openapi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): use a configmap index [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5948:
URL: https://github.com/apache/camel-k/pull/5948#issuecomment-2480603800
fyi @hernanDatgDev I've tested this against your reproducer and it seems the root issue is fixed. Please, have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): use a configmap index [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5948:
URL: https://github.com/apache/camel-k/pull/5948#issuecomment-2486348880
Hi @hernanDatgDev, please, let's stick to the original reproducer reported in https://github.com/apache/camel-k/issues/5924#issuecomment-2463315268 to avoid mixing up things. I've removed the response content and I manage to reproduce your same problem with runtime 3.15.0 (Camel core 4.8.0). However, this is a different problem from the one we're fixing in this PR.
I've run the same reproducer against runtime 3.8.1 and the issue is not appearing, so, there is some regression or new behavior introduced in the new Camel core 4.8.0. From Camel K perspective we can't really do anything until that is fixed in the core unfortunately. I suggest you please open an issue and report this in the core. It also may be a core fix, given that we may expect a response to always provide a content, but I am not into openapi spec details to confirm that.
As for this PR, please, feel free to have a look and verify if the original issue is solved, so I can merge accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): use a configmap index [camel-k]
Posted by "hernanDatgDev (via GitHub)" <gi...@apache.org>.
hernanDatgDev commented on PR #5948:
URL: https://github.com/apache/camel-k/pull/5948#issuecomment-2484649795
@squakez I pulled your fork and built the project locally. For some reason I'm getting a rest dsl plugin failure when my integration is building.
I've been struggling with the root cause. Is there some difference between v2.4 and 2.5 RE how the project is built or the api spec that's required for this to work? I feel like I must be missing something obvious.
```
{"level":"error","ts":"2024-11-19T03:31:47Z","logger":"camel-k.maven.build","msg":"Failed to execute goal org.apache.camel.k:camel-k-maven-plugin:3.15.0:generate-rest-xml (default) on project camel-k-rest-d │
│ sl-generator: Exception while generating rest xml: Cannot invoke \"io.swagger.v3.oas.models.media.Content.entrySet()\" because the return value of \"io.swagger.v3.oas.models.responses.ApiResponse.getContent()\" is null -> [Help 1]","stac │
│ ktrace":"github.com/apache/camel-k/v2/pkg/util/log.Logger.Error\n\tgithub.com/apache/camel-k/v2/pkg/util/log/log.go:80\ngithub.com/apache/camel-k/v2/pkg/util/maven.normalizeLog\n\tgithub.com/apache/camel-k/v2/pkg/util/maven/maven_log.go: │
│ 87\ngithub.com/apache/camel-k/v2/pkg/util/maven.LogHandler\n\tgithub.com/apache/camel-k/v2/pkg/util/maven/maven_log.go:53\ngithub.com/apache/camel-k/v2/pkg/util.scan\n\tgithub.com/apache/camel-k/v2/pkg/util/command.go:76\ngithub.com/apac │
│ he/camel-k/v2/pkg/util.RunAndLog.func1\n\tgithub.com/apache/camel-k/v2/pkg/util/command.go:55\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\tgolang.org/x/sync@v0.9.0/errgroup/errgroup.go:78"}
```
For reference here's the api spec I'm including in my referenced configmap:
```
openapi: 3.0.3
info:
title: Basic API
version: "1.0"
paths:
/test:
post:
operationId: test
responses:
200:
description: Default response
/user/{userId}:
get:
operationId: getUser
parameters:
- name: userId
in: path
required: true
schema:
type: string
responses:
200:
description: Default response
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): use a configmap index [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5948:
URL: https://github.com/apache/camel-k/pull/5948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org