[GitHub] [flink] JingsongLi commented on a change in pull request #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner
URL: https://github.com/apache/flink/pull/8234#discussion_r277948264
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/plan/batch/sql/CalcTest.xml
 ##########
 @@ -85,7 +85,7 @@ LogicalProject(a=[$0], b=[$1], c=[$2], d=[$3])
     </Resource>
     <Resource name="planAfter">
       <![CDATA[
-Calc(select=[a, CAST(1984-07-12) AS b, CAST(14:34:24) AS c, CAST(1984-07-12 14:34:24) AS d], where=[AND(=(b, 1984-07-12), =(c, 14:34:24), =(d, 1984-07-12 14:34:24))])
+Calc(select=[a, CAST(1984-07-12) AS b, CAST(14:34:24) AS c, CAST(1984-07-12 14:34:24:TIMESTAMP(3)) AS d], where=[AND(=(b, 1984-07-12), =(c, 14:34:24), =(d, 1984-07-12 14:34:24:TIMESTAMP(3)))])
 
 Review comment:
   @walterddr I think the reason is the modify of `RexLiteral.toJavaString` in https://github.com/apache/calcite/pull/1002 , The `Timestamp` default precision is 3, I think it hasn't changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services