You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by jiny2 <gi...@git.apache.org> on 2015/11/05 13:40:50 UTC

[GitHub] incubator-hawq pull request: HAWQ-128. Cleanup pg_resqueue impact ...

GitHub user jiny2 opened a pull request:

    https://github.com/apache/incubator-hawq/pull/77

    HAWQ-128. Cleanup pg_resqueue impact in catalog and dump correspondin…

    1) Make pg_dumpall able to dump resource queue DDL statments. Support building tree structured resource queues from pg_dumpall output.
    
    2) pg_stat_resqueues() is expired, pg_resqueue_status can provide the same information.
    
    postgres=# select * from pg_resqueue_status;
      rsqname   | segmem | segcore  | segsize | segsizemax | inusemem | inusecore | rsqholders | rsqwaiters | paused
    ------------+--------+----------+---------+------------+----------+-----------+------------+------------+--------
     pg_root    | 128    | 0.062500 | 64      | 64         | 0        | 0.000000  | 0          | 0          | F
     pg_default | 128    | 0.062500 | 32      | 64         | 0        | 0.000000  | 0          | 0          | F
    (2 rows)
    
    3) Removed some legacy code referencing pg_resourcetype and pg_resqueuecapability.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiny2/incubator-hawq HAWQ-128-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 81ca6c8c7863b2cafee24b9ec88cf935f96c0d9a
Author: Yi Jin <yj...@pivotal.io>
Date:   2015-11-05T12:35:39Z

    HAWQ-128. Cleanup pg_resqueue impact in catalog and dump corresponding components

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-128. Cleanup pg_resqueue impact ...

Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/77#issuecomment-154273110
  
    Hi Yi, 
    
    I think it is better to keep the name of pg_stat_resqueues() unchanged. Otherwise it is hard for user or DBA to keep legacy application/doc/tools working. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-128. Cleanup pg_resqueue impact ...

Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/77#issuecomment-154343843
  
    Hi Yi,
    
    The purposes for these 2 views pg_catalog.pg_stat_resqueues and gp_toolkit.gp_resqueue_status are different. 
    - The first one is used to monitor a resource queue's workload over time from the aspect of queries' execution time.
    - The second one is focus on each resource queue's limitation setting(quota) and the resource has been occupied by active queries.
    
    So you can't delete any of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-128. Cleanup pg_resqueue impact ...

Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-128. Cleanup pg_resqueue impact ...

Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/77#issuecomment-154286714
  
    pg_resqueue_status is another existing UDF/view as well. I think pg_stat_resqueues is redundant. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---