You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jv...@apache.org on 2006/09/27 11:28:53 UTC

svn commit: r450387 - in /maven/components/branches/maven-2.1-jvz: maven-toolchain/src/main/java/org/apache/maven/Toolchain.java maven.iws

Author: jvanzyl
Date: Wed Sep 27 02:28:52 2006
New Revision: 450387

URL: http://svn.apache.org/viewvc?view=rev&rev=450387
Log: (empty)

Modified:
    maven/components/branches/maven-2.1-jvz/maven-toolchain/src/main/java/org/apache/maven/Toolchain.java
    maven/components/branches/maven-2.1-jvz/maven.iws

Modified: maven/components/branches/maven-2.1-jvz/maven-toolchain/src/main/java/org/apache/maven/Toolchain.java
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1-jvz/maven-toolchain/src/main/java/org/apache/maven/Toolchain.java?view=diff&rev=450387&r1=450386&r2=450387
==============================================================================
--- maven/components/branches/maven-2.1-jvz/maven-toolchain/src/main/java/org/apache/maven/Toolchain.java (original)
+++ maven/components/branches/maven-2.1-jvz/maven-toolchain/src/main/java/org/apache/maven/Toolchain.java Wed Sep 27 02:28:52 2006
@@ -1,5 +1,11 @@
 package org.apache.maven;
 
+//languages like java, .net, ruby, c++                                                                
+//device specific like j2me where there are profiles for different devices
+//groups where you have 1.4, 1.5
+//versions where you have things like 1.4_003 and 1.5_006
+//app servers possibly
+
 /**
  * @author Milos Kleint
  * @author Jason van Zyl
@@ -12,12 +18,22 @@
 
     String getVendor();
 
-    String getSpecification();
+    String getSpecificationVersion();
+
+    String getVersion();
 
     Map getProperties();
 
     Map getSystemProperties();
 
+    /**
+     * Gets the platform tool executable.
+     *
+     * @param toolName the tool platform independent tool name.
+     * @return file representing the tool executable, or null if the tool can not be found
+     */
+    String findTool( String toolName );
+
     //JAVA
     /**
      * Returns a ClassPath, which represents bootstrap libraries for the
@@ -34,14 +50,6 @@
      * it corresponds to contents of CLASSPATH environment variable.
      */
     List getStandardLibraries();
-
-    /**
-     * Gets the platform tool executable.
-     *
-     * @param toolName the tool platform independent tool name.
-     * @return file representing the tool executable, or null if the tool can not be found
-     */
-    String findTool( String toolName );
 
     //JAVA
     /**

Modified: maven/components/branches/maven-2.1-jvz/maven.iws
URL: http://svn.apache.org/viewvc/maven/components/branches/maven-2.1-jvz/maven.iws?view=diff&rev=450387&r1=450386&r2=450387
==============================================================================
--- maven/components/branches/maven-2.1-jvz/maven.iws (original)
+++ maven/components/branches/maven-2.1-jvz/maven.iws Wed Sep 27 02:28:52 2006
@@ -148,7 +148,7 @@
       <file leaf-file-name="Toolchain.java" pinned="false" current="true" current-in-tab="true">
         <entry file="file://$PROJECT_DIR$/maven-toolchain/src/main/java/org/apache/maven/Toolchain.java">
           <provider selected="true" editor-type-id="text-editor">
-            <state line="50" column="0" selection-start="1210" selection-end="1210" vertical-scroll-proportion="0.66172105">
+            <state line="49" column="69" selection-start="1342" selection-end="1342" vertical-scroll-proportion="0.8189911">
               <folding />
             </state>
           </provider>
@@ -1107,7 +1107,7 @@
     </entry>
     <entry file="file://$PROJECT_DIR$/maven-toolchain/src/main/java/org/apache/maven/Toolchain.java">
       <provider selected="true" editor-type-id="text-editor">
-        <state line="50" column="0" selection-start="1210" selection-end="1210" vertical-scroll-proportion="0.66172105">
+        <state line="49" column="69" selection-start="1342" selection-end="1342" vertical-scroll-proportion="0.8189911">
           <folding />
         </state>
       </provider>



Re: svn commit: r450387 - in /maven/components/branches/maven-2.1-jvz: maven-toolchain/src/main/java/org/apache/maven/Toolchain.java maven.iws

Posted by Jason van Zyl <ja...@maven.org>.
On 27 Sep 06, at 2:22 PM 27 Sep 06, Brett Porter wrote:

>
> On 27/09/2006, at 7:28 PM, jvanzyl@apache.org wrote:
>
>>
>> +//versions where you have things like 1.4_003 and 1.5_006
>
> what's the issue here?

The general specification like 1.5 in theory should be fine most of  
the time, but the specific version is used to find bugs or work  
around bugs. Building with one version of a JDK and something  
working, while in the next release it does not. You might have  
profiles that use every possible version of JavaToolChain you can to  
test thoroughly so we might end up one's for each version so we just  
have to account for each version and have a way to point to it  
specifically when someone has all versions of JDK 1.5 for example.

>
>> +//app servers possibly
>
> That seems like a separate kettle of fish.
>

Yup, some netbeans folks straightened me out.

> - Brett
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Jason van Zyl
jason@maven.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r450387 - in /maven/components/branches/maven-2.1-jvz: maven-toolchain/src/main/java/org/apache/maven/Toolchain.java maven.iws

Posted by Brett Porter <br...@apache.org>.
On 27/09/2006, at 7:28 PM, jvanzyl@apache.org wrote:

>
> +//versions where you have things like 1.4_003 and 1.5_006

what's the issue here?

> +//app servers possibly

That seems like a separate kettle of fish.

- Brett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org