You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org> on 2026/09/09 18:07:54 UTC
[PR] feat(computing-unit): name the configuration a unit cannot start without [texera]
tanishqgandhi1908 opened a new pull request, #8472:
URL: https://github.com/apache/texera/pull/8472
### What changes were proposed in this PR?
Six environment variables were read with `Option.get`, so a deployment missing any of them failed with `None.get`. Dropwizard shows that as "There was an error processing your request" — no variable named, no cause, and six candidates to check.
Every missing variable is now listed at once, as a 503. All at once because when these are missing they are usually all missing: the helm chart supplies all six, so they are present together or absent together.
```
Before: one unset -> 500 "There was an error processing your request"
After: any unset -> 503 naming every missing variable
```
Also fixes the default computing-unit image, which named a personal repository that is gone. It now points at what this repository publishes, which is what the helm chart already sets.
**No change for any working deployment.** When the six variables are set the map built is identical. The helm chart always sets `KUBERNETES_IMAGE_NAME`, so the default only affects a service run outside the chart — where today no unit starts at all.
### Any related issues, documentation, discussions?
Closes #8467
Part of #8466
### How was this PR tested?
Three new tests for `requiredComputingUnitEnv` (all set, one missing, all missing), and the existing default-image assertion updated.
```
sbt "ComputingUnitManagingService/testOnly org.apache.texera.service.resource.ComputingUnitManagingResourceSpec"
"Config/testOnly org.apache.texera.common.config.KubernetesConfigSpec"
ComputingUnitManagingResourceSpec 34 passed, 0 failed
KubernetesConfigSpec 6 passed, 0 failed
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit): name the configuration a unit cannot start without [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8472:
URL: https://github.com/apache/texera/pull/8472#issuecomment-5610188157
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8472?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.96%. Comparing base ([`bda3400`](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0c8867e`](https://app.codecov.io/gh/apache/texera/commit/0c8867e88c3334791ae74fbfa7dc0015f88797af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8472 +/- ##
============================================
+ Coverage 93.94% 93.96% +0.02%
Complexity 4826 4826
============================================
Files 1209 1209
Lines 49705 49692 -13
Branches 6074 6074
============================================
Hits 46694 46694
+ Misses 1522 1509 -13
Partials 1489 1489
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.18% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.91% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.35% <ø> (+2.30%)` | :arrow_up: | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.12% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.65% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.77% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.47% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8472?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit): name the configuration a unit cannot start without [texera]
Posted by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org>.
tanishqgandhi1908 commented on PR #8472:
URL: https://github.com/apache/texera/pull/8472#issuecomment-5607120144
/request-review @aicam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit): name the configuration a unit cannot start without [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8472:
URL: https://github.com/apache/texera/pull/8472#issuecomment-5608834976
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@zyratlo`, `@aglinxinyuan`
You can notify them by mentioning `@zyratlo`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit): name the configuration a unit cannot start without [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8472:
URL: https://github.com/apache/texera/pull/8472#issuecomment-5610799140
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 6 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `ec3a9dd` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/34402176554)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 410 | 0.25 | 23,800/32,297/32,297 us | 🔴 +12.3% / 🔴 +98.8% |
| 🔴 | bs=100 sw=10 sl=64 | 934 | 0.57 | 107,448/127,418/127,418 us | 🔴 +5.1% / 🔴 +17.3% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,078 | 0.658 | 923,495/1,046,043/1,046,043 us | 🔴 +7.1% / 🟢 -7.5% |
<details><summary>Baseline details</summary>
Latest main `ec3a9dd` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 410 tuples/sec | 448 tuples/sec | 754.83 tuples/sec | -8.5% | -45.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.25 MB/s | 0.274 MB/s | 0.461 MB/s | -8.8% | -45.7% |
| bs=10 sw=10 sl=64 | p50 | 23,800 us | 21,189 us | 12,950 us | +12.3% | +83.8% |
| bs=10 sw=10 sl=64 | p95 | 32,297 us | 33,405 us | 16,243 us | -3.3% | +98.8% |
| bs=10 sw=10 sl=64 | p99 | 32,297 us | 33,405 us | 19,574 us | -3.3% | +65.0% |
| bs=100 sw=10 sl=64 | throughput | 934 tuples/sec | 975 tuples/sec | 982.46 tuples/sec | -4.2% | -4.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.57 MB/s | 0.595 MB/s | 0.6 MB/s | -4.2% | -4.9% |
| bs=100 sw=10 sl=64 | p50 | 107,448 us | 102,232 us | 101,575 us | +5.1% | +5.8% |
| bs=100 sw=10 sl=64 | p95 | 127,418 us | 126,270 us | 108,655 us | +0.9% | +17.3% |
| bs=100 sw=10 sl=64 | p99 | 127,418 us | 126,270 us | 121,794 us | +0.9% | +4.6% |
| bs=1000 sw=10 sl=64 | throughput | 1,078 tuples/sec | 1,102 tuples/sec | 1,010 tuples/sec | -2.2% | +6.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.658 MB/s | 0.673 MB/s | 0.616 MB/s | -2.2% | +6.8% |
| bs=1000 sw=10 sl=64 | p50 | 923,495 us | 910,938 us | 998,032 us | +1.4% | -7.5% |
| bs=1000 sw=10 sl=64 | p95 | 1,046,043 us | 976,592 us | 1,039,429 us | +7.1% | +0.6% |
| bs=1000 sw=10 sl=64 | p99 | 1,046,043 us | 976,592 us | 1,068,120 us | +7.1% | -2.1% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,487.44,200,128000,410,0.250,23799.82,32296.63,32296.63
1,100,10,64,20,2141.94,2000,1280000,934,0.570,107448.22,127417.92,127417.92
2,1000,10,64,20,18546.35,20000,12800000,1078,0.658,923495.24,1046043.39,1046043.39
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit): name the configuration a unit cannot start without [texera]
Posted by "aicam (via GitHub)" <gi...@apache.org>.
aicam merged PR #8472:
URL: https://github.com/apache/texera/pull/8472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org