You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/21 05:29:20 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #8306: Support exclude the message when reset cursor by message ID

sijie commented on a change in pull request #8306:
URL: https://github.com/apache/pulsar/pull/8306#discussion_r508998499



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -1216,15 +1217,17 @@ public void resetCursorOnPosition(
             @ApiParam(value = "Is authentication required to perform this operation")
             @QueryParam("authoritative") @DefaultValue("false") boolean authoritative,
             @ApiParam(name = "messageId", value = "messageId to reset back to (ledgerId:entryId)")
-            MessageIdImpl messageId) {
+                    ResetCursorData resetCursorData) {

Review comment:
       How did you maintain backward compatibility on this endpoint?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org