You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Juan Manuel CABRERA (JIRA)" <ji...@apache.org> on 2012/08/27 09:40:08 UTC
[jira] [Created] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Juan Manuel CABRERA created FEDIZ-25:
----------------------------------------
Summary: Look for fediz_config.xml in catalina base too
Key: FEDIZ-25
URL: https://issues.apache.org/jira/browse/FEDIZ-25
Project: CXF-Fediz
Issue Type: Improvement
Components: Plugin
Affects Versions: 1.0.0, 1.0.1
Reporter: Juan Manuel CABRERA
Priority: Trivial
The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Posted by "Juan Manuel CABRERA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Manuel CABRERA updated FEDIZ-25:
-------------------------------------
Attachment: FederationAuthenticator.java.patch
Hi Glen,
I don't have any definitive opinion about this neither. The enclosed patch searches CATALINA_BASE only, this seems to be the "clean" stand after having read the documentation you pointed me to (thanks for taking time to do so by the way) and corrects 1.
This ends up being a lame patch, but hey! I don't care, this is my first one :)
Regards,
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Priority: Trivial
> Attachments: FederationAuthenticator.java.patch, FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FEDIZ-25) Look for fediz_config.xml in
catalina base too
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442403#comment-13442403 ]
Glen Mazza edited comment on FEDIZ-25 at 8/28/12 12:27 AM:
-----------------------------------------------------------
Hi, couple of issues with the patch:
1.) To reduce confusion, the name of the local variable at line #144 should be changed to "String catalinaBase", not "catalinaHome" anymore, as the former will equal the latter if the former isn't explicitly defined (http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Introduction), so catalinaBase is the way to go. We're always reading from catalinaBase (which will always have a value), so that's the appropriate name for the value.
2.) I don't like the change in the first half of your patch, around line #105 -- you read from catalinaBase iff catalinaHome is not producing a valid file. That logic seems wrong, catalinaBase must have precedence for configuration files, see "Advanced Configuration - Multiple Tomcat Instances" section here: http://tomcat.apache.org/tomcat-7.0-doc/RUNNING.txt, "conf" section. That same section implies that $CATALINA_HOME/conf folder is *not* searched if it is not found in $CATALINA_BASE/conf, however the Tomcat team is wishy-washy on that (http://tomcat.10.n6.nabble.com/CATALINA-BASE-and-CATALINA-HOME-deployment-tp4981258p4981264.html). Whether or not we should attempt to read from $CATALINA_HOME/conf if it's not already present in $CATALINA_BASE/conf (where CATALINA_HOME != CATALINA_BASE), I have no strong opinion on either way.
Thanks!
was (Author: gmazza):
Hi, couple of issues with the patch:
1.) To reduce confusion, the name of the local variable at line #144 should be changed to "String catalinaBase", not "catalinaHome" anymore, as the former will equal the latter if the former isn't explicitly defined (http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Introduction), so catalinaBase is the way to go. We're always reading from catalinaBase (which will always have a value), so that's the appropriate name for the value.
2.) I don't like the change in the first half of your patch, around line #105 -- you read from catalinaBase iff catalinaHome is not producing a valid file--that logic seems wrong, catalinaBase must have precedence for configuration files--see "Advanced Configuration - Multiple Tomcat Instances" section here: http://tomcat.apache.org/tomcat-7.0-doc/RUNNING.txt, "conf" section. That same section implies that $CATALINA_HOME/conf folder is *not* searched if it is not found in $CATALINA_BASE/conf, however the Tomcat team is wishy-washy on that (http://tomcat.10.n6.nabble.com/CATALINA-BASE-and-CATALINA-HOME-deployment-tp4981258p4981264.html). Whether or not we should attempt to read from $CATALINA_HOME/conf if it's not already present in $CATALINA_BASE/conf (where CATALINA_HOME != CATALINA_BASE), I have no strong opinion on either way.
Thanks!
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Priority: Trivial
> Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Posted by "Oliver Wulff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Wulff updated FEDIZ-25:
------------------------------
Fix Version/s: 1.0.2
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Assignee: Glen Mazza
> Priority: Trivial
> Fix For: 1.0.2
>
> Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Posted by "Juan Manuel CABRERA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Manuel CABRERA updated FEDIZ-25:
-------------------------------------
Attachment: FederationAuthenticator.java.patch
Proposed patch
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Priority: Trivial
> Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442403#comment-13442403 ]
Glen Mazza commented on FEDIZ-25:
---------------------------------
Hi, couple of issues with the patch:
1.) To reduce confusion, the name of the local variable at line #144 should be changed to "String catalinaBase", not "catalinaHome" anymore, as the former will equal the latter if the former isn't explicitly defined (http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Introduction), so catalinaBase is the way to go. We're always reading from catalinaBase (which will always have a value), so that's the appropriate name for the value.
2.) I don't like the change in the first half of your patch, around line #105 -- you read from catalinaBase iff catalinaHome is not producing a valid file--that logic seems wrong, catalinaBase must have precedence for configuration files--see "Advanced Configuration - Multiple Tomcat Instances" section here: http://tomcat.apache.org/tomcat-7.0-doc/RUNNING.txt, "conf" section. That same section implies that $CATALINA_HOME/conf folder is *not* searched if it is not found in $CATALINA_BASE/conf, however the Tomcat team is wishy-washy on that (http://tomcat.10.n6.nabble.com/CATALINA-BASE-and-CATALINA-HOME-deployment-tp4981258p4981264.html). Whether or not we should attempt to read from $CATALINA_HOME/conf if it's not already present in $CATALINA_BASE/conf (where CATALINA_HOME != CATALINA_BASE), I have no strong opinion on either way.
Thanks!
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Priority: Trivial
> Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Posted by "Juan Manuel CABRERA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Manuel CABRERA updated FEDIZ-25:
-------------------------------------
Attachment: (was: FederationAuthenticator.java.patch)
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Priority: Trivial
> Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Mazza resolved FEDIZ-25.
-----------------------------
Resolution: Fixed
Patch applied, thanks. I checked that CATALINA_BASE is defined as CATALINA_HOME if former is undefined (and hence the reading of the $CATALINA_HOME/conf/fediz-config.xml will still occur as before.) However running multiple Fediz-enabled Tomcat instances using a common CATALINA_BASE is quite complex and can raise several other issues; please report back if you find anything.
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Assignee: Glen Mazza
> Priority: Trivial
> Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FEDIZ-25) Look for fediz_config.xml in catalina
base too
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FEDIZ-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Mazza reassigned FEDIZ-25:
-------------------------------
Assignee: Glen Mazza
> Look for fediz_config.xml in catalina base too
> ----------------------------------------------
>
> Key: FEDIZ-25
> URL: https://issues.apache.org/jira/browse/FEDIZ-25
> Project: CXF-Fediz
> Issue Type: Improvement
> Components: Plugin
> Affects Versions: 1.0.0, 1.0.1
> Reporter: Juan Manuel CABRERA
> Assignee: Glen Mazza
> Priority: Trivial
> Attachments: FederationAuthenticator.java.patch
>
>
> The FederationAuthenticator valve looks for the Fediz configuration file in the catalina_home only, it should be fetched in the catalina_base too to address the cases where both variables are different (which is the case with WTP by default for instance, or in many production deployment)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira