You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2024/03/27 02:36:59 UTC
[PR] Remove kenai code from versioning modules and deprecate friend API [netbeans]
mbien opened a new pull request, #7198:
URL: https://github.com/apache/netbeans/pull/7198
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning and bugtracking modules [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#issuecomment-2028838014
> I would not have made api incompatible changes in mercurial, but given that the "API" is friend-only with a single user
I must have misunderstood your review comment then. What is the friend export you are worried about? There is still time to revert things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning and bugtracking modules [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#discussion_r1545468078
##########
ide/bugzilla/src/org/netbeans/modules/bugzilla/issue/IssuePanel.java:
##########
@@ -512,7 +508,7 @@ void reloadForm(boolean force) {
clearHighlights();
boolean isNew = issue.isNew();
- boolean showProductCombo = isNew || !(issue.getRepository() instanceof KenaiRepository) || NBBugzillaUtils.isNbRepository(issue.getRepository().getUrl());
+ boolean showProductCombo = true;
Review Comment:
@matthiasblaesing the code either displays the product property as combo box or as text field if it is a kenai project.
with kenai gone, I believe it is ok to always display it as combo box, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning and bugtracking modules [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #7198:
URL: https://github.com/apache/netbeans/pull/7198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning modules and deprecate friend API [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#discussion_r1544909111
##########
ide/bugzilla/src/org/netbeans/modules/bugzilla/issue/IssuePanel.java:
##########
@@ -512,7 +508,7 @@ void reloadForm(boolean force) {
clearHighlights();
boolean isNew = issue.isNew();
- boolean showProductCombo = isNew || !(issue.getRepository() instanceof KenaiRepository) || NBBugzillaUtils.isNbRepository(issue.getRepository().getUrl());
+ boolean showProductCombo = true;
Review Comment:
my thinking was that `!(issue.getRepository() instanceof KenaiRepository)` is essentially always evaluating to true now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning modules and deprecate friend API [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#discussion_r1544885607
##########
ide/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/repository/RepositoryComboSupportTest.java:
##########
@@ -70,8 +69,7 @@ public class RepositoryComboSupportTest {
@BeforeClass
public static void setLookup() {
- MockLookup.setLayersAndInstances(
- new DummyKenaiRepositories(),
+ MockLookup.setLayersAndInstances(new DummyRepositories(),
Review Comment:
```suggestion
MockLookup.setLayersAndInstances(
new DummyRepositories(),
```
##########
ide/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/team/DummyRepositories.java:
##########
@@ -17,9 +17,8 @@
* under the License.
*/
-package org.netbeans.modules.bugtracking.kenai;
+package org.netbeans.modules.bugtracking.team;
Review Comment:
```suggestion
package org.netbeans.modules.bugtracking.dummies;
```
This is a hunch - but in `RepositoryComboSupportTest` all other dummy implementations reside in the `dummies` package.
##########
ide/bugzilla/src/org/netbeans/modules/bugzilla/issue/IssuePanel.java:
##########
@@ -512,7 +508,7 @@ void reloadForm(boolean force) {
clearHighlights();
boolean isNew = issue.isNew();
- boolean showProductCombo = isNew || !(issue.getRepository() instanceof KenaiRepository) || NBBugzillaUtils.isNbRepository(issue.getRepository().getUrl());
+ boolean showProductCombo = true;
Review Comment:
```suggestion
boolean showProductCombo = isNew || NBBugzillaUtils.isNbRepository(issue.getRepository().getUrl());
```
or kill `NBBugzillaUtils` and change to:
```suggestion
boolean showProductCombo = isNew;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning and bugtracking modules [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#issuecomment-2028216617
pushed a commit
- bumps spec version in ide/mercurial and ide/versioning.util
- removes the deprecated stubs I left and also all other deprecated code of the versioning modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning and bugtracking modules [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#issuecomment-2028930014
> > I would not have made api incompatible changes in mercurial, but given that the "API" is friend-only with a single user
>
> I must have misunderstood your review comment then. What is the friend export you are worried about? There is still time to revert things.
Sorry for the misunderstanding. My final comment was directed at the changes in `ide/mercurial/src/org/netbeans/modules/mercurial/api/Mercurial.java`. I don't remember, that they were in the original changeset (or I overlooked them). My first glance trigger my "API!!!"-reflex (from package name) and the second look then showed that the mercurial module has no public api.
It is done and cleanup, so I suggest to keep the change and merge as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning modules and deprecate friend API [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#issuecomment-2022826874
I guess, Kenai was unplugged in 2017 with no replacement.
Do we have a policy for effective removal ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning modules and deprecate friend API [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#issuecomment-2022859967
> Do we have a policy for effective removal?
I am not aware of a policy. This does not touch public API as you can see since no sig tests failed. I am planning to keep the friend api like `VCSKenaiAccessor` in the repo, but deprecate it with `forRemoval=true`, so it can be removed once there is a public api removal policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning and bugtracking modules [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#discussion_r1545468078
##########
ide/bugzilla/src/org/netbeans/modules/bugzilla/issue/IssuePanel.java:
##########
@@ -512,7 +508,7 @@ void reloadForm(boolean force) {
clearHighlights();
boolean isNew = issue.isNew();
- boolean showProductCombo = isNew || !(issue.getRepository() instanceof KenaiRepository) || NBBugzillaUtils.isNbRepository(issue.getRepository().getUrl());
+ boolean showProductCombo = true;
Review Comment:
@matthiasblaesing the code either displays the product field as combo box or as text field if it is a kenai project.
with kenai gone, I believe it is ok to always display it as combo box, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove kenai code from versioning and bugtracking modules [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7198:
URL: https://github.com/apache/netbeans/pull/7198#discussion_r1545452270
##########
ide/bugzilla/src/org/netbeans/modules/bugzilla/issue/IssuePanel.java:
##########
@@ -512,7 +508,7 @@ void reloadForm(boolean force) {
clearHighlights();
boolean isNew = issue.isNew();
- boolean showProductCombo = isNew || !(issue.getRepository() instanceof KenaiRepository) || NBBugzillaUtils.isNbRepository(issue.getRepository().getUrl());
+ boolean showProductCombo = true;
Review Comment:
i checked and NBBugzillaUtils is probably something for another PR (if at all possible). Since it sits in `team.commons` which has a much bigger friends list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists