[GitHub] [incubator-pekko-site] jrudolph commented on a diff in pull request #14: Add sbt-github-actions for basic CI

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #14:
URL: https://github.com/apache/incubator-pekko-site/pull/14#discussion_r1250377700


##########
.github/workflows/ci.yml:
##########
@@ -0,0 +1,47 @@
+# This file was automatically generated by sbt-github-actions using the
+# githubWorkflowGenerate task. You should add and commit this file to
+# your git repository. It goes without saying that you shouldn't edit
+# this file by hand! Instead, if you wish to make changes, you should
+# change your sbt build configuration to revise the workflow description
+# to meet your needs, then regenerate this file.
+
+name: Continuous Integration
+
+on:
+  pull_request:
+    branches: [main]
+  push:
+    branches: [main]
+    tags: [v*]
+
+env:
+  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+jobs:
+  build:
+    name: Build and Test
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        scala: [2.12.18]

Review Comment:
   ```suggestion
           scala: [2.12]
   ```
   
   Btw. why is it running on 2.12 in the first place?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org