[GitHub] [iceberg] jacobmarble commented on a diff in pull request #8658: API: add type Timestampns

["jacobmarble (via GitHub)" <gi...@apache.org>]

jacobmarble commented on code in PR #8658:
URL: https://github.com/apache/iceberg/pull/8658#discussion_r1341569544


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -48,6 +48,8 @@ private Types() {}
           .put(TimeType.get().toString(), TimeType.get())
           .put(TimestampType.withZone().toString(), TimestampType.withZone())
           .put(TimestampType.withoutZone().toString(), TimestampType.withoutZone())
+          .put(TimestampnsType.withZone().toString(), TimestampnsType.withZone())

Review Comment:
   @JFinis we discussed `timestamp[MILLIS|MICROS|NANOS]` in [the proposal/design doc](https://docs.google.com/document/d/1bE1DcEGNzZAMiVJSZ0X1wElKLNkT9kRkk0hDlfkXzvU/edit), but decided against it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org