You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/10/30 03:22:22 UTC
Re: Review Request 63403: RANGER-1862:generalName.get(1) cause
IndexOutOfBoundsException in NiFiClient
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/
-----------------------------------------------------------
(Updated 十月 30, 2017, 3:22 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-1862:generalName.get(1) cause IndexOutOfBoundsException in NiFiClient
Bugs: RANGER-1862
https://issues.apache.org/jira/browse/RANGER-1862
Repository: ranger
Description
-------
when generalName.size() <=1 , generalName.get(1) cause IndexOutOfBoundsException in NiFiClient.java
Diffs (updated)
-----
plugin-nifi/src/main/java/org/apache/ranger/services/nifi/client/NiFiClient.java c03bc12
Diff: https://reviews.apache.org/r/63403/diff/2/
Changes: https://reviews.apache.org/r/63403/diff/1-2/
Testing
-------
tested it
Thanks,
Qiang Zhang
Re: Review Request 63403: RANGER-1862:generalName.get(1) cause
IndexOutOfBoundsException in NiFiClient
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/#review189630
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 30, 2017, 3:22 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63403/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 3:22 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1862
> https://issues.apache.org/jira/browse/RANGER-1862
>
>
> Repository: ranger
>
>
> Description
> -------
>
> when generalName.size() <=1 , generalName.get(1) cause IndexOutOfBoundsException in NiFiClient.java
>
>
> Diffs
> -----
>
> plugin-nifi/src/main/java/org/apache/ranger/services/nifi/client/NiFiClient.java c03bc12
>
>
> Diff: https://reviews.apache.org/r/63403/diff/2/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 63403: RANGER-1862:generalName.get(1) cause
IndexOutOfBoundsException in NiFiClient
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/#review189789
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Nov. 1, 2017, 8:12 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63403/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2017, 8:12 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1862
> https://issues.apache.org/jira/browse/RANGER-1862
>
>
> Repository: ranger
>
>
> Description
> -------
>
> when generalName.size() <=1 , generalName.get(1) cause IndexOutOfBoundsException in NiFiClient.java
>
>
> Diffs
> -----
>
> plugin-nifi/src/main/java/org/apache/ranger/services/nifi/client/NiFiClient.java c03bc12
>
>
> Diff: https://reviews.apache.org/r/63403/diff/3/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 63403: RANGER-1862:generalName.get(1) cause
IndexOutOfBoundsException in NiFiClient
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/#review190009
-----------------------------------------------------------
Ship it!
Ship It!
- pengjianhua
On 十一月 1, 2017, 8:12 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63403/
> -----------------------------------------------------------
>
> (Updated 十一月 1, 2017, 8:12 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1862
> https://issues.apache.org/jira/browse/RANGER-1862
>
>
> Repository: ranger
>
>
> Description
> -------
>
> when generalName.size() <=1 , generalName.get(1) cause IndexOutOfBoundsException in NiFiClient.java
>
>
> Diffs
> -----
>
> plugin-nifi/src/main/java/org/apache/ranger/services/nifi/client/NiFiClient.java c03bc12
>
>
> Diff: https://reviews.apache.org/r/63403/diff/3/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 63403: RANGER-1862:generalName.get(1) cause
IndexOutOfBoundsException in NiFiClient
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/
-----------------------------------------------------------
(Updated 十一月 1, 2017, 8:12 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
Bugs: RANGER-1862
https://issues.apache.org/jira/browse/RANGER-1862
Repository: ranger
Description
-------
when generalName.size() <=1 , generalName.get(1) cause IndexOutOfBoundsException in NiFiClient.java
Diffs (updated)
-----
plugin-nifi/src/main/java/org/apache/ranger/services/nifi/client/NiFiClient.java c03bc12
Diff: https://reviews.apache.org/r/63403/diff/3/
Changes: https://reviews.apache.org/r/63403/diff/2-3/
Testing
-------
tested it
Thanks,
Qiang Zhang
Re: Review Request 63403: RANGER-1862:generalName.get(1) cause
IndexOutOfBoundsException in NiFiClient
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 十月 31, 2017, 11:19 a.m., Colm O hEigeartaigh wrote:
> > Please put the comment above the if statement.
Ok,I have updated the patch please review again.Thanks.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/#review189705
-----------------------------------------------------------
On 十一月 1, 2017, 8:12 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63403/
> -----------------------------------------------------------
>
> (Updated 十一月 1, 2017, 8:12 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1862
> https://issues.apache.org/jira/browse/RANGER-1862
>
>
> Repository: ranger
>
>
> Description
> -------
>
> when generalName.size() <=1 , generalName.get(1) cause IndexOutOfBoundsException in NiFiClient.java
>
>
> Diffs
> -----
>
> plugin-nifi/src/main/java/org/apache/ranger/services/nifi/client/NiFiClient.java c03bc12
>
>
> Diff: https://reviews.apache.org/r/63403/diff/3/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 63403: RANGER-1862:generalName.get(1) cause
IndexOutOfBoundsException in NiFiClient
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/#review189705
-----------------------------------------------------------
Please put the comment above the if statement.
- Colm O hEigeartaigh
On Oct. 30, 2017, 3:22 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63403/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 3:22 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1862
> https://issues.apache.org/jira/browse/RANGER-1862
>
>
> Repository: ranger
>
>
> Description
> -------
>
> when generalName.size() <=1 , generalName.get(1) cause IndexOutOfBoundsException in NiFiClient.java
>
>
> Diffs
> -----
>
> plugin-nifi/src/main/java/org/apache/ranger/services/nifi/client/NiFiClient.java c03bc12
>
>
> Diff: https://reviews.apache.org/r/63403/diff/2/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>