You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/17 14:02:27 UTC

[GitHub] [airflow] c-wilson commented on a change in pull request #7740: [AIRFLOW-7065] Add optional propagation of task std streams to console

c-wilson commented on a change in pull request #7740: [AIRFLOW-7065] Add optional propagation of task std streams to console
URL: https://github.com/apache/airflow/pull/7740#discussion_r393701172
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -141,8 +140,8 @@ def _run_file_processor(result_channel,
 
         try:
             # redirect stdout/stderr to log
-            with redirect_stdout(StreamLogWriter(log, logging.INFO)),\
-                    redirect_stderr(StreamLogWriter(log, logging.WARN)):
+            with StdoutToLog(log, logging.INFO), \
+                    StderrToLog(log, logging.WARN):
 
 Review comment:
   Just made this change for consistency, but you are correct that it is not necessary. Probably not actually helpful either on second look. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services