You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2007/05/22 02:26:16 UTC
[jira] Resolved: (BEANUTILS-266) Log or throw exception in
PropertyUtilsBean, not both
[ https://issues.apache.org/jira/browse/BEANUTILS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton resolved BEANUTILS-266.
---------------------------------------
Resolution: Fixed
Assignee: Niall Pemberton
Sorry forget that - I've re-produced and added a test - closing as fixed
> Log or throw exception in PropertyUtilsBean, not both
> -----------------------------------------------------
>
> Key: BEANUTILS-266
> URL: https://issues.apache.org/jira/browse/BEANUTILS-266
> Project: Commons BeanUtils
> Issue Type: Improvement
> Components: Bean / Property Utils
> Affects Versions: 1.7.0
> Environment: all
> Reporter: Brian Ewins
> Assigned To: Niall Pemberton
> Priority: Minor
> Fix For: 1.8.0
>
>
> This commit (related to BEANUTILS-224):
> http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java?view=diff&r1=471989&r2=471990
> improved the error message for illegal arguments, but also introduced a log message for that same exception. Best practice is to log or throw but not both, since this often results in the error being logged multiple times - when it was created and when the exception is caught. In addition this is logging the problem as an error when it may in fact be handled by the caller, so at worst its a debug-level message.
> I switched up to 1.7 recently and this has been filling up my logs. I know I can work around it by disabling logging for this component but the existence of this log message seems like an oversight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org