You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Vladimir Tretyakov (JIRA)" <ji...@apache.org> on 2014/10/14 21:10:35 UTC
[jira] [Comment Edited] (KAFKA-1481) Stop using dashes AND
underscores as separators in MBean names
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171371#comment-14171371 ]
Vladimir Tretyakov edited comment on KAFKA-1481 at 10/14/14 7:09 PM:
---------------------------------------------------------------------
Hi, Jun,
Thx that you found a time to look at patch, I've added another regarding your suggestion, now in JMX you will see (hope it is what you need):
{code}
"kafka.server":type="FetcherStats",name="RequestsPerSec",clientId="af_servers",threadName="ConsumerFetcherThread",groupId="af_servers",consumerHostName="wawanawna",timestamp="1413306414731",uuid="4624cb0f",fetcherId="0",sourceBrokerId="0",brokerHost="wawanawna",brokerPort="9092"
"kafka.server":type="FetcherLagMetrics",name="ConsumerLag",clientId="af_servers",threadName="ConsumerFetcherThread",groupId="af_servers",consumerHostName="wawanawna",timestamp="1413306414731",uuid="4624cb0f",fetcherId="0",sourceBrokerId="0",brokerHost="wawanawna",brokerPort="9092",topic="spm_topic",partitionId="0"
"kafka.consumer":type="ZookeeperConsumerConnector",name="OwnedPartitionsCount",clientId="af_servers",groupId="af_servers",topic="spm_topic"
"kafka.consumer":type="FetchRequestAndResponseMetrics",name="FetchResponseSize",clientId="af_servers",threadName="ConsumerFetcherThread",groupId="af_servers",consumerHostName="wawanawna",timestamp="1413306414731",uuid="4624cb0f",fetcherId="0",sourceBrokerId="0",allBrokers="true"
{code}
{quote}
Also, your patch doesn't seem to apply to latest trunk.
git apply ~/Downloads/KAFKA-1481_2014-10-13_18-23-35.patch
error: core/src/main/scala/kafka/common/ClientIdTopic.scala: No such file or directory
{quote}
Interesting...
1. I've worked with 0.8.2 branch, not trunk
2. ClientIdTopic.scala - I've added this file (must be in patch).
Added 2 equal patches (created them in different way):
1. 'git diff' (KAFKA-1481_2014-10-14_21-53-35.patch)
2. With help from IDEA IDE. (KAFKA-1481_IDEA_IDE_2014-10-14_21-53-35.patch)
Try please, maybe one of them will work
Thx again.
was (Author: vladimir.tretyakov):
Hi, Jun,
Thx that you found a time to look at patch, I've added another regarding your suggestion, now in JMX you will see (hope it is what you need):
{code}
"kafka.server":type="FetcherStats",name="RequestsPerSec",clientId="af_servers",threadName="ConsumerFetcherThread",groupId="af_servers",consumerHostName="wawanawna",timestamp="1413306414731",uuid="4624cb0f",fetcherId="0",sourceBrokerId="0",brokerHost="wawanawna",brokerPort="9092"
"kafka.server":type="FetcherLagMetrics",name="ConsumerLag",clientId="af_servers",threadName="ConsumerFetcherThread",groupId="af_servers",consumerHostName="wawanawna",timestamp="1413306414731",uuid="4624cb0f",fetcherId="0",sourceBrokerId="0",brokerHost="wawanawna",brokerPort="9092",topic="spm_topic",partitionId="0"
"kafka.consumer":type="ZookeeperConsumerConnector",name="OwnedPartitionsCount",clientId="af_servers",groupId="af_servers",topic="spm_topic"
"kafka.consumer":type="FetchRequestAndResponseMetrics",name="FetchResponseSize",clientId="af_servers",threadName="ConsumerFetcherThread",groupId="af_servers",consumerHostName="wawanawna",timestamp="1413306414731",uuid="4624cb0f",fetcherId="0",sourceBrokerId="0",allBrokers="true"
{code}
{quote}
Also, your patch doesn't seem to apply to latest trunk.
git apply ~/Downloads/KAFKA-1481_2014-10-13_18-23-35.patch
error: core/src/main/scala/kafka/common/ClientIdTopic.scala: No such file or directory
{quote}
Interesting...
1. I've worked with 0.8.2 branch, not trunk
2. ClientIdTopic.scala - I've added this file (must be in patch).
Added 2 equal patches (created them in different way):
1. 'git diff'
2. With help from IDEA IDE.
Try please, maybe one of them will work
Thx again.
> Stop using dashes AND underscores as separators in MBean names
> --------------------------------------------------------------
>
> Key: KAFKA-1481
> URL: https://issues.apache.org/jira/browse/KAFKA-1481
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Reporter: Otis Gospodnetic
> Priority: Critical
> Labels: patch
> Fix For: 0.8.2
>
> Attachments: KAFKA-1481_2014-06-06_13-06-35.patch, KAFKA-1481_2014-10-13_18-23-35.patch, KAFKA-1481_2014-10-14_21-53-35.patch, KAFKA-1481_IDEA_IDE_2014-10-14_21-53-35.patch
>
>
> MBeans should not use dashes or underscores as separators because these characters are allowed in hostnames, topics, group and consumer IDs, etc., and these are embedded in MBeans names making it impossible to parse out individual bits from MBeans.
> Perhaps a pipe character should be used to avoid the conflict.
> This looks like a major blocker because it means nobody can write Kafka 0.8.x monitoring tools unless they are doing it for themselves AND do not use dashes AND do not use underscores.
> See: http://search-hadoop.com/m/4TaT4lonIW
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)