You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2023/05/23 13:15:02 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
mrhhsg opened a new pull request, #19973:
URL: https://github.com/apache/doris/pull/19973
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19973:
URL: https://github.com/apache/doris/pull/19973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560389745
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.69 seconds
stream load tsv: 443 seconds loaded 74807831229 Bytes, about 161 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 74.7 seconds inserted 10000000 Rows, about 133K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230524025724_clickbench_pr_149288.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1562161489
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.65 seconds
stream load tsv: 445 seconds loaded 74807831229 Bytes, about 160 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 25.5 seconds inserted 10000000 Rows, about 392K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230525021406_clickbench_pr_150033.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560405458
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1562130711
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205206078
##########
be/src/util/bitmap_value.h:
##########
@@ -1828,6 +2309,27 @@ class BitmapValue {
}
return count;
}
+ case SET: {
+ int64_t count = 0;
+ std::vector<uint64_t> values;
Review Comment:
reserve vector for performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1565462121
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560892968
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205209738
##########
be/src/util/bitmap_value.h:
##########
@@ -1828,6 +2309,27 @@ class BitmapValue {
}
return count;
}
+ case SET: {
+ int64_t count = 0;
+ std::vector<uint64_t> values;
+ for (auto v : _set) {
+ values.emplace_back(v);
Review Comment:
only push back values which `>= range_start`, to reduce sort elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1566754413
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1567683521
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1569260276
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560884554
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1559342706
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1208755070
##########
be/src/common/config.cpp:
##########
@@ -998,6 +998,8 @@ DEFINE_mInt32(s3_write_buffer_whole_size, "524288000");
//disable shrink memory by default
DEFINE_Bool(enable_shrink_memory, "false");
+DEFINE_Bool(enable_set_in_bitmap_value, "true");
Review Comment:
we need pick it to 1.2.5 and set its default value to false. And then in 2.x we need set it to true to remove the if-else. Because it will change the storage format. @cambyzju
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205125340
##########
be/src/util/bitmap_value.h:
##########
@@ -1959,16 +2511,31 @@ class BitmapValue {
_is_shared = false;
}
+ void _convert_to_bitmap_if_need() {
+ if (_type != SET || _set.size() <= SET_TYPE_THRESHOLD) {
+ return;
+ }
+ _prepare_bitmap_for_write();
+ for (auto v : _set) {
+ _bitmap->add(v);
+ }
+ _type = BITMAP;
+ _set.clear();
+ }
+
enum BitmapDataType {
EMPTY = 0,
SINGLE = 1, // single element
- BITMAP = 2 // more than one elements
+ SET = 2, // elements count less or equal than 32
Review Comment:
could we keep `BITMAP = 2` and add `SET = 3` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205130190
##########
be/src/util/bitmap_value.h:
##########
@@ -1742,17 +2186,43 @@ class BitmapValue {
return _sv;
case BITMAP:
return _bitmap->maximum();
+ case SET:
+ return _max_in_set();
default:
return 0;
}
}
uint64_t max(bool* empty) const {
- return min_or_max(empty, [&]() { return _bitmap->maximum(); });
+ return min_or_max(empty, [&]() { return maximum(); });
}
uint64_t min(bool* empty) const {
- return min_or_max(empty, [&]() { return _bitmap->minimum(); });
+ return min_or_max(empty, [&]() { return minimum(); });
+ }
+
+ uint64_t _min_in_set() const {
+ uint64_t result = std::numeric_limits<uint64_t>::max();
+ if (_type == SET) {
Review Comment:
```suggestion
DCHECK(_type == SET);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zenoyang commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "zenoyang (via GitHub)" <gi...@apache.org>.
zenoyang commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205120276
##########
be/src/util/bitmap_value.h:
##########
@@ -1311,6 +1382,53 @@ class BitmapValue {
case BITMAP:
_prepare_bitmap_for_write();
*_bitmap |= *rhs._bitmap;
+ break;
+ case SET: {
+ _prepare_bitmap_for_write();
+ *_bitmap = *rhs._bitmap;
+
+ for (auto v : _set) {
+ _bitmap->add(v);
+ }
+ _type = SET;
Review Comment:
Should it be `_type = BITMAP` here?
##########
be/src/util/bitmap_value.h:
##########
@@ -1331,37 +1450,103 @@ class BitmapValue {
case BITMAP:
bitmaps.push_back(value->_bitmap.get());
break;
+ case SET:
+ sets.push_back(&value->_set);
+ break;
}
}
if (!bitmaps.empty()) {
_prepare_bitmap_for_write();
+ *_bitmap = detail::Roaring64Map::fastunion(bitmaps.size(), bitmaps.data());
switch (_type) {
case EMPTY:
- *_bitmap = detail::Roaring64Map::fastunion(bitmaps.size(), bitmaps.data());
- _type = BITMAP;
break;
case SINGLE:
- *_bitmap = detail::Roaring64Map::fastunion(bitmaps.size(), bitmaps.data());
_bitmap->add(_sv);
- _type = BITMAP;
break;
case BITMAP:
- *_bitmap |= detail::Roaring64Map::fastunion(bitmaps.size(), bitmaps.data());
+ break;
+ case SET: {
+ for (auto v : _set) {
+ _bitmap->add(v);
+ }
+ _set.clear();
break;
}
+ }
+ _type = BITMAP;
+ }
+
+ if (!sets.empty()) {
+ for (auto& set : sets) {
+ for (auto v : *set) {
+ _set.insert(v);
+ }
+ }
+ switch (_type) {
+ case EMPTY:
+ _type = SET;
+ break;
+ case SINGLE: {
+ _set.insert(_sv);
+ _type = SET;
+ _convert_to_bitmap_if_need();
+ break;
+ }
+ case BITMAP:
+ _prepare_bitmap_for_write();
+ for (auto v : _set) {
+ _bitmap->add(v);
+ }
+ _type = BITMAP;
+ break;
+ case SET: {
+ _convert_to_bitmap_if_need();
+ break;
+ }
+ }
}
if (_type == EMPTY && single_values.size() == 1) {
_sv = single_values[0];
_type = SINGLE;
} else if (!single_values.empty()) {
- _prepare_bitmap_for_write();
- _bitmap->addMany(single_values.size(), single_values.data());
- if (_type == SINGLE) {
- _bitmap->add(_sv);
+ switch (_type) {
+ case EMPTY:
+ case SINGLE:
+ if (config::enable_set_in_bitmap_value) {
+ _set.insert(single_values.cbegin(), single_values.cend());
+ if (_type == SINGLE) {
+ _set.insert(_sv);
+ }
+ if (_set.size() == 1) {
+ _type = SINGLE;
+ _sv = *_set.begin();
+ _set.clear();
+ } else {
+ _type = SET;
+ _convert_to_bitmap_if_need();
+ }
+ } else {
+ _prepare_bitmap_for_write();
+ _bitmap->addMany(single_values.size(), single_values.data());
+ if (_type == SINGLE) {
+ _bitmap->add(_sv);
+ }
+ _type = SET;
Review Comment:
Should it be `_type = BITMAP` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1566870913
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1567217694
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1561222883
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.13 seconds
stream load tsv: 445 seconds loaded 74807831229 Bytes, about 160 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 25.5 seconds inserted 10000000 Rows, about 392K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230524140218_clickbench_pr_149859.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560470711
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.3 seconds
stream load tsv: 456 seconds loaded 74807831229 Bytes, about 156 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 76.7 seconds inserted 10000000 Rows, about 130K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230524051702_clickbench_pr_149411.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1566754646
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1566761729
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205124041
##########
be/src/util/bitmap_value.h:
##########
@@ -1959,16 +2511,31 @@ class BitmapValue {
_is_shared = false;
}
+ void _convert_to_bitmap_if_need() {
+ if (_type != SET || _set.size() <= SET_TYPE_THRESHOLD) {
+ return;
+ }
+ _prepare_bitmap_for_write();
+ for (auto v : _set) {
+ _bitmap->add(v);
+ }
+ _type = BITMAP;
+ _set.clear();
+ }
+
enum BitmapDataType {
EMPTY = 0,
SINGLE = 1, // single element
- BITMAP = 2 // more than one elements
+ SET = 2, // elements count less or equal than 32
+ BITMAP = 3 // more than one elements
};
uint64_t _sv = 0; // store the single value when _type == SINGLE
std::shared_ptr<detail::Roaring64Map> _bitmap; // used when _type == BITMAP
+ phmap::flat_hash_set<uint64_t> _set;
BitmapDataType _type {EMPTY};
// Indicate whether the state is shared among multi BitmapValue object
bool _is_shared = true;
+ static constexpr uint64_t SET_TYPE_THRESHOLD = 32;
Review Comment:
why `SET_TYPE_THRESHOLD == 32` ? Is there any performance test reports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1567695051
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1566403613
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1562132515
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1567036845
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560356939
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1567215063
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1569257909
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1559586940
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1559536152
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560403923
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1562347762
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1566403638
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205201471
##########
be/src/util/bitmap_value.h:
##########
@@ -1909,14 +2446,28 @@ class BitmapValue {
void _convert_to_smaller_type() {
if (_type == BITMAP) {
uint64_t c = _bitmap->cardinality();
- if (c > 1) return;
+ if (config::enable_set_in_bitmap_value && c > SET_TYPE_THRESHOLD) {
+ return;
+ } else if (c > 1) {
+ return;
+ }
if (c == 0) {
_type = EMPTY;
- } else {
+ } else if (c == 1) {
_type = SINGLE;
_sv = _bitmap->minimum();
+ } else {
+ _type = SET;
+ for (auto v : *_bitmap) {
+ _set.insert(v);
+ }
}
_bitmap.reset();
+ } else if (_type == SET) {
+ if (_set.size() == 1) {
+ _type = SINGLE;
+ _sv = *_set.begin();
+ }
Review Comment:
else if set.size == 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1565541402
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.92 seconds
stream load tsv: 443 seconds loaded 74807831229 Bytes, about 161 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 25.5 seconds inserted 10000000 Rows, about 392K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230527155255_clickbench_pr_151907.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205117014
##########
be/src/common/config.cpp:
##########
@@ -998,6 +998,8 @@ DEFINE_mInt32(s3_write_buffer_whole_size, "524288000");
//disable shrink memory by default
DEFINE_Bool(enable_shrink_memory, "false");
+DEFINE_Bool(enable_set_in_bitmap_value, "true");
Review Comment:
1. we need add more comment about enable_set_in_bitmap_value and SET_TYPE_THRESHOLD.
2. we should better close new feature by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205117014
##########
be/src/common/config.cpp:
##########
@@ -998,6 +998,8 @@ DEFINE_mInt32(s3_write_buffer_whole_size, "524288000");
//disable shrink memory by default
DEFINE_Bool(enable_shrink_memory, "false");
+DEFINE_Bool(enable_set_in_bitmap_value, "true");
Review Comment:
we need add more comment about enable_set_in_bitmap_value and SET_TYPE_THRESHOLD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1208027343
##########
be/src/util/bitmap_value.h:
##########
@@ -1888,6 +2414,17 @@ class BitmapValue {
}
break;
}
+ case SET: {
+ std::vector<uint64_t> values;
+ for (auto v : _set) {
+ values.emplace_back(v);
+ }
+ std::sort(values.begin(), values.end());
Review Comment:
Yes, `std::set` is good enough when the elements' count is negligible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1565460604
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205215021
##########
be/src/util/bitmap_value.h:
##########
@@ -1888,6 +2414,17 @@ class BitmapValue {
}
break;
}
+ case SET: {
+ std::vector<uint64_t> values;
+ for (auto v : _set) {
+ values.emplace_back(v);
+ }
+ std::sort(values.begin(), values.end());
Review Comment:
std::set or phmap::flat_hash_set is better for at most 32 elements?
if std::set is not too bad, we can avoid copy to array and sort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1559526416
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1559604041
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560953843
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19973: [improvement](bitmap) Using set to store a small number of elements to improve performance
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19973:
URL: https://github.com/apache/doris/pull/19973#issuecomment-1560355278
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org