You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/15 02:01:28 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request #30043: [SPARK-33136][SQL][BRANCH-2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
HeartSaVioR opened a new pull request #30043:
URL: https://github.com/apache/spark/pull/30043
### What changes were proposed in this pull request?
This PR proposes to fix a bug on calling `DataType.equalsIgnoreCompatibleNullability` with mistakenly swapped parameters in `AppendData.outputResolved`. The order of parameters for `DataType.equalsIgnoreCompatibleNullability` are `from` and `to`, which says that the right order of matching variables are `inAttr` and `outAttr`.
### Why are the changes needed?
Although the problematic part is a dead code, once we know there's a bug, preferably we'd like to fix that.
### Does this PR introduce _any_ user-facing change?
No, as this fixes the dead code.
### How was this patch tested?
This patch fixes the dead code, which is not easy to craft a test. (The test in original commit is no longer valid here.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30043: [SPARK-33136][SQL][BRANCH-2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708866463
Thank you so much, @HeartSaVioR !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #30043: [SPARK-33136][SQL][BRANCH-2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708847185
cc. @dongjoon-hyun
I just ported back only the fix, not test, because the test requires catalog implementation which is only available in 3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30043:
URL: https://github.com/apache/spark/pull/30043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708874886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30043: [SPARK-33136][SQL][BRANCH-2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708858908
**[Test build #129785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129785/testReport)** for PR 30043 at commit [`162f6fe`](https://github.com/apache/spark/commit/162f6fed6c34ff60286850832f77321e543568a0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708858908
**[Test build #129785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129785/testReport)** for PR 30043 at commit [`162f6fe`](https://github.com/apache/spark/commit/162f6fed6c34ff60286850832f77321e543568a0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708867560
Thanks for reviewing and merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708939886
**[Test build #129785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129785/testReport)** for PR 30043 at commit [`162f6fe`](https://github.com/apache/spark/commit/162f6fed6c34ff60286850832f77321e543568a0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708940619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708874886
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708874890
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34392/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30043: [SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30043:
URL: https://github.com/apache/spark/pull/30043#issuecomment-708940619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org