[jira] [Work logged] (GOBBLIN-1937) Quantify Missed Work Completed by Reminders

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1937?focusedWorklogId=887303&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887303 ]

ASF GitHub Bot logged work on GOBBLIN-1937:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Oct/23 23:10
            Start Date: 25/Oct/23 23:10
    Worklog Time Spent: 10m 
      Work Description: umustafi opened a new pull request, #3808:
URL: https://github.com/apache/gobblin/pull/3808

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1937
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   Measure the amount of work that would have been missed by a participant otherwise completed by the reminder event concept. This can be done by checking the number of reminder events that actually obtain a lease to re-trigger a flow launch. Reminder events that see another lease is in progress are not included to avoid double counting the participant actually doing the work on reminder case. 
   Additionally, address a bug to filter out heartbeat events before attempting to extract the FlowActionType from DagActionStoreChangeEvents because heartbeat events have null FlowActionTypes, causing the heartbeats to be rightfully skipped but for the wrong reason. 
   
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   N/A metric emission 
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 887303)
    Remaining Estimate: 0h
            Time Spent: 10m

> Quantify Missed Work Completed by Reminders
> -------------------------------------------
>
>                 Key: GOBBLIN-1937
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1937
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Measure the amount of work that would have been missed by a participant otherwise completed by the reminder event concept. This can be done by checking the number of reminder events that actually obtain a lease to re-trigger a flow launch. Reminder events that see another lease is in progress are not included to avoid double counting the participant actually doing the work on reminder case. 
> Additionally, address a bug to filter out heartbeat events _before_ attempting to extract the {{FlowActionType}} from {{DagActionStoreChangeEvents}} because heartbeat events have null {{{}FlowActionTypes{}}}, causing the heartbeats to be rightfully skipped but for the wrong reason. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)