You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/06 23:04:29 UTC
[GitHub] [beam] cushon opened a new pull request, #24930: Improve Error Prone configuration
cushon opened a new pull request, #24930:
URL: https://github.com/apache/beam/pull/24930
Pass the required `--add-exports=` flags whenever the current JDK supports them, instead of relying on `java17Home` being set.
Also upgrade the Error Prone version, and remove obsolete 'errorproneJavac' configuration.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] cushon commented on a diff in pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
cushon commented on code in PR #24930:
URL: https://github.com/apache/beam/pull/24930#discussion_r1065118036
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -778,6 +778,7 @@ class BeamModulePlugin implements Plugin<Project> {
// Disabling checks since this property is only used for Jenkins tests
// https://github.com/tbroyer/gradle-errorprone-plugin#jdk-16-support
options.errorprone.errorproneArgs.add("-XepDisableAllChecks")
+ // The -J prefix is needed to workaround https://github.com/gradle/gradle/issues/22747
Review Comment:
> Is this the right issue?
Thanks, that should have been https://github.com/gradle/gradle/issues/22746, I pushed a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys merged pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
kileys merged PR #24930:
URL: https://github.com/apache/beam/pull/24930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] cushon commented on a diff in pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
cushon commented on code in PR #24930:
URL: https://github.com/apache/beam/pull/24930#discussion_r1064875307
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1282,6 +1283,27 @@ class BeamModulePlugin implements Plugin<Project> {
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.excludedPaths = '(.*/)?(build/generated-src|build/generated.*avro-java|build/generated)/.*'
+ // Error Prone requires some packages to be exported/opened for Java 17.
+ // This logic handles builds running on JDK 17, notusing -Djava17Home.
+ // The -J prefix is not needed if forkOptions.javaHome is unset,
+ // see http://github.com/gradle/gradle/issues/22747
+ if (JavaVersion.VERSION_1_8.compareTo(JavaVersion.current()) < 0
Review Comment:
I update the comment. The flags should be passed to all Java versions that support modules (Java 9 and up), and became mandatory for Java 17 and newer versions. So checking for `version > 8` instead of `version == 17` is deliberate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24930:
URL: https://github.com/apache/beam/pull/24930#issuecomment-1374276691
# [Codecov](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24930](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7796a9a) into [master](https://codecov.io/gh/apache/beam/commit/f9d5de34ae1dad251f5580073c0245a206224a69?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9d5de3) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24930 +/- ##
==========================================
- Coverage 73.17% 73.08% -0.10%
==========================================
Files 731 734 +3
Lines 97958 98095 +137
==========================================
+ Hits 71677 71688 +11
- Misses 24922 25048 +126
Partials 1359 1359
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `82.67% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
| [...am/testing/benchmarks/cloudml/criteo\_tft/criteo.py](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2Nsb3VkbWwvY3JpdGVvX3RmdC9jcml0ZW8ucHk=) | `0.00% <0.00%> (ø)` | |
| [...m/testing/benchmarks/cloudml/pipelines/workflow.py](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2Nsb3VkbWwvcGlwZWxpbmVzL3dvcmtmbG93LnB5) | `6.94% <0.00%> (ø)` | |
| [...chmarks/cloudml/cloudml\_benchmark\_constants\_lib.py](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2Nsb3VkbWwvY2xvdWRtbF9iZW5jaG1hcmtfY29uc3RhbnRzX2xpYi5weQ==) | `100.00% <0.00%> (ø)` | |
| [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/24930?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `81.88% <0.00%> (+0.14%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
kileys commented on PR #24930:
URL: https://github.com/apache/beam/pull/24930#issuecomment-1376348739
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24930:
URL: https://github.com/apache/beam/pull/24930#issuecomment-1374285978
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
kileys commented on PR #24930:
URL: https://github.com/apache/beam/pull/24930#issuecomment-1376312937
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24930:
URL: https://github.com/apache/beam/pull/24930#issuecomment-1375777747
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24930:
URL: https://github.com/apache/beam/pull/24930#discussion_r1064751547
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1282,6 +1283,27 @@ class BeamModulePlugin implements Plugin<Project> {
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.excludedPaths = '(.*/)?(build/generated-src|build/generated.*avro-java|build/generated)/.*'
+ // Error Prone requires some packages to be exported/opened for Java 17.
+ // This logic handles builds running on JDK 17, notusing -Djava17Home.
+ // The -J prefix is not needed if forkOptions.javaHome is unset,
+ // see http://github.com/gradle/gradle/issues/22747
+ if (JavaVersion.VERSION_1_8.compareTo(JavaVersion.current()) < 0
Review Comment:
Is this actually specific to JDK 17? If so, we should probably do exact equality, if not the comment should be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24930:
URL: https://github.com/apache/beam/pull/24930#issuecomment-1375775087
R: @kileys could you take a look since this is a Java 17 change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on a diff in pull request #24930: Improve Error Prone configuration
Posted by GitBox <gi...@apache.org>.
kileys commented on code in PR #24930:
URL: https://github.com/apache/beam/pull/24930#discussion_r1065114260
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -778,6 +778,7 @@ class BeamModulePlugin implements Plugin<Project> {
// Disabling checks since this property is only used for Jenkins tests
// https://github.com/tbroyer/gradle-errorprone-plugin#jdk-16-support
options.errorprone.errorproneArgs.add("-XepDisableAllChecks")
+ // The -J prefix is needed to workaround https://github.com/gradle/gradle/issues/22747
Review Comment:
Is this the right issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org