You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/09/29 09:05:13 UTC
Review Request 62686: RANGER-1816:When the error occurs,
the system does not record the error message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua, and Ramesh Mani.
Bugs: RANGER-1816
https://issues.apache.org/jira/browse/RANGER-1816
Repository: ranger
Description
-------
these java files are as follows:
RangerPolicyService.java
XGroupService.java
XUserService.java
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java f55a103
security-admin/src/main/java/org/apache/ranger/service/XGroupService.java fd57430
security-admin/src/main/java/org/apache/ranger/service/XUserService.java 9be833c
Diff: https://reviews.apache.org/r/62686/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 62686: RANGER-1816:When the error occurs,
the system does not record the error message
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/#review187428
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 9, 2017, 2:49 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62686/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 2:49 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua, and Ramesh Mani.
>
>
> Bugs: RANGER-1816
> https://issues.apache.org/jira/browse/RANGER-1816
>
>
> Repository: ranger
>
>
> Description
> -------
>
> these java files are as follows:
> RangerPolicyService.java
> XGroupService.java
> XUserService.java
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java f55a103
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java fd57430
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 9be833c
>
>
> Diff: https://reviews.apache.org/r/62686/diff/2/
>
>
> Testing
> -------
>
> Tested!
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 62686: RANGER-1816:When the error occurs,
the system does not record the error message
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/#review187482
-----------------------------------------------------------
Ship it!
Ship It!
- pengjianhua
On Oct. 9, 2017, 2:49 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62686/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 2:49 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua, and Ramesh Mani.
>
>
> Bugs: RANGER-1816
> https://issues.apache.org/jira/browse/RANGER-1816
>
>
> Repository: ranger
>
>
> Description
> -------
>
> these java files are as follows:
> RangerPolicyService.java
> XGroupService.java
> XUserService.java
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java f55a103
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java fd57430
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 9be833c
>
>
> Diff: https://reviews.apache.org/r/62686/diff/2/
>
>
> Testing
> -------
>
> Tested!
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 62686: RANGER-1816:When the error occurs,
the system does not record the error message
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/
-----------------------------------------------------------
(Updated 十月 9, 2017, 2:49 a.m.)
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua, and Ramesh Mani.
Bugs: RANGER-1816
https://issues.apache.org/jira/browse/RANGER-1816
Repository: ranger
Description
-------
these java files are as follows:
RangerPolicyService.java
XGroupService.java
XUserService.java
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java f55a103
security-admin/src/main/java/org/apache/ranger/service/XGroupService.java fd57430
security-admin/src/main/java/org/apache/ranger/service/XUserService.java 9be833c
Diff: https://reviews.apache.org/r/62686/diff/2/
Changes: https://reviews.apache.org/r/62686/diff/1-2/
Testing
-------
Tested!
Thanks,
Qiang Zhang
Re: Review Request 62686: RANGER-1816:When the error occurs,
the system does not record the error message
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 九月 29, 2017, 1:14 p.m., Colm O hEigeartaigh wrote:
> > I think it's better to pass the exception as an argument and not implicitly call toString(), e.g. logger.error("Get transaction log failure.", illegalAcc);
> > Also change "Get transaction log failure" to just "Transaction log failure"
I have updated the patch,thanks!
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/#review186666
-----------------------------------------------------------
On 九月 29, 2017, 9:05 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62686/
> -----------------------------------------------------------
>
> (Updated 九月 29, 2017, 9:05 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua, and Ramesh Mani.
>
>
> Bugs: RANGER-1816
> https://issues.apache.org/jira/browse/RANGER-1816
>
>
> Repository: ranger
>
>
> Description
> -------
>
> these java files are as follows:
> RangerPolicyService.java
> XGroupService.java
> XUserService.java
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java f55a103
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java fd57430
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 9be833c
>
>
> Diff: https://reviews.apache.org/r/62686/diff/1/
>
>
> Testing
> -------
>
> Tested!
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 62686: RANGER-1816:When the error occurs,
the system does not record the error message
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/#review186666
-----------------------------------------------------------
I think it's better to pass the exception as an argument and not implicitly call toString(), e.g. logger.error("Get transaction log failure.", illegalAcc);
Also change "Get transaction log failure" to just "Transaction log failure"
- Colm O hEigeartaigh
On Sept. 29, 2017, 9:05 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62686/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 9:05 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua, and Ramesh Mani.
>
>
> Bugs: RANGER-1816
> https://issues.apache.org/jira/browse/RANGER-1816
>
>
> Repository: ranger
>
>
> Description
> -------
>
> these java files are as follows:
> RangerPolicyService.java
> XGroupService.java
> XUserService.java
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java f55a103
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java fd57430
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 9be833c
>
>
> Diff: https://reviews.apache.org/r/62686/diff/1/
>
>
> Testing
> -------
>
> Tested!
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 62686: RANGER-1816:When the error occurs,
the system does not record the error message
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/
-----------------------------------------------------------
(Updated 九月 29, 2017, 9:05 a.m.)
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua, and Ramesh Mani.
Bugs: RANGER-1816
https://issues.apache.org/jira/browse/RANGER-1816
Repository: ranger
Description
-------
these java files are as follows:
RangerPolicyService.java
XGroupService.java
XUserService.java
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java f55a103
security-admin/src/main/java/org/apache/ranger/service/XGroupService.java fd57430
security-admin/src/main/java/org/apache/ranger/service/XUserService.java 9be833c
Diff: https://reviews.apache.org/r/62686/diff/1/
Testing (updated)
-------
Tested!
Thanks,
Qiang Zhang