You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fjtirado (via GitHub)" <gi...@apache.org> on 2025/10/07 16:41:22 UTC
[PR] [Fix #4080] Modularizing open api [incubator-kie-kogito-runtimes]
fjtirado opened a new pull request, #4083:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4083
Fix https://github.com/apache/incubator-kie-kogito-runtimes/issues/4080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #4080] Modularizing open api [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado merged PR #4083:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #4080] Modularizing open api [incubator-kie-kogito-runtimes]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #4083:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4083#discussion_r2414075714
##########
quarkus/addons/token-exchange/runtime/pom.xml:
##########
@@ -41,18 +41,9 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-arc</artifactId>
</dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-oidc-client</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>io.quarkiverse.openapi.generator</groupId>
- <artifactId>quarkus-openapi-generator</artifactId>
- </dependency>
<dependency>
<groupId>org.apache.kie.sonataflow</groupId>
- <artifactId>sonataflow-quarkus</artifactId>
+ <artifactId>sonataflow-addons-quarkus-openapi</artifactId>
Review Comment:
IIRC OIDC is required - I imagine you moved it to `sonataflow-addons-quarkus-openapi`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #4080] Modularizing open api [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #4083:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4083#discussion_r2416235354
##########
quarkus/addons/token-exchange/runtime/pom.xml:
##########
@@ -41,18 +41,9 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-arc</artifactId>
</dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-oidc-client</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>io.quarkiverse.openapi.generator</groupId>
- <artifactId>quarkus-openapi-generator</artifactId>
- </dependency>
<dependency>
<groupId>org.apache.kie.sonataflow</groupId>
- <artifactId>sonataflow-quarkus</artifactId>
+ <artifactId>sonataflow-addons-quarkus-openapi</artifactId>
Review Comment:
yes, I moved it there, since I think is of not use if openapi is not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org