[GitHub] [incubator-superset] ktmud commented on issue #9593: Re-enable table filter, fix #8273 #8683

[GitBox <gi...@apache.org>]

ktmud commented on issue #9593:
URL: https://github.com/apache/incubator-superset/pull/9593#issuecomment-617277211


   > I want to make table filter as simple as possible, otherwise it's really hard to maintain the majority usage.
   
   I agree. Actually tried to do a bigger refactor to simply some code pieces, but it ended up breaking many of the test cases you mentioned. Current solution is the simplest I could find that didn't break anything.
   
   To be honest, I'm even not sure about the value of this feature. Under which use cases it is irreplaceable by a FilterBox? If the burden of maintaining it outweighs the benefits, I'm in favor of officially deprecating it and focusing on improving the filter box instead.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org