You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dentiny (via GitHub)" <gi...@apache.org> on 2026/03/26 07:05:03 UTC
[PR] fix(delete): poll deleter close future on exit [opendal]
dentiny opened a new pull request, #7316:
URL: https://github.com/apache/opendal/pull/7316
# Which issue does this PR close?
Closes https://github.com/apache/opendal/issues/7315
# Rationale for this change
On delete sink close, current implementation directly creates and drops close future, inside of which batch delete all left unsent requests.
# What changes are included in this PR?
This PR checks close future before exit, to make sure all left unsent requests are taken care of.
# Are there any user-facing changes?
No.
# AI Usage Statement
Opus 4.6 crafted tests to trigger the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(delete): poll deleter close future on exit [opendal]
Posted by "dentiny (via GitHub)" <gi...@apache.org>.
dentiny commented on PR #7316:
URL: https://github.com/apache/opendal/pull/7316#issuecomment-4132212337
Failed CI not related to my change :(
```sh
info: syncing channel updates for 'stable-aarch64-apple-darwin'
error: failed to download file error=Reqwest(reqwest::Error { kind: Request, url: "https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256", source: TimedOut })
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to '/Users/runner/.rustup/tmp/m1dniga3gy13b2f5_file': error downloading file: error sending request for url (https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256): operation timed out
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(delete): poll deleter close future on exit [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #7316:
URL: https://github.com/apache/opendal/pull/7316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org