[GitHub] [nuttx] pussuw commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

[GitBox <gi...@apache.org>]

pussuw commented on code in PR #7966:
URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059980713


##########
include/nuttx/sched.h:
##########
@@ -1054,6 +1058,30 @@ FAR struct task_tcb_s *nxtask_setup_vfork(start_t retaddr);
 pid_t nxtask_start_vfork(FAR struct task_tcb_s *child);
 void nxtask_abort_vfork(FAR struct task_tcb_s *child, int errcode);
 
+/****************************************************************************
+ * Name: group_addrenv_attach
+ *
+ * Description:
+ *   Attach address environment to a newly created group. Called by exec()
+ *   right before injecting the new process into the system.
+ *
+ * Input Parameters:
+ *   tcb     - The tcb of the newly loaded task.
+ *   addrenv - The address environment that is attached.
+ *
+ * Returned Value:
+ *   This is a NuttX internal function so it follows the convention that
+ *   0 (OK) is returned on success and a negated errno is returned on
+ *   failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARCH_ADDRENV
+struct group_addrenv_s;

Review Comment:
   You are right, I assumed there would not be visibility to arch/arch but I was wrong. Will remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org