You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/15 08:00:34 UTC
[GitHub] [inlong] yunqingmoswu opened a new pull request, #5071: [INLONG-5070][Manager] Add more parameter settings support for stream source
yunqingmoswu opened a new pull request, #5071:
URL: https://github.com/apache/inlong/pull/5071
### Prepare a Pull Request
*(Change the title refer to the following example)*
Title: [INLONG-5070][Manager] Add more parameter settings support for stream source
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
Fixes #5070
### Motivation
Add more parameter settings support for stream source. At present, each connector on the sort-connectors side supports a large number of parameter settings, but the manager only exposes a small part of them, so the manager also needs to expose related parameter settings.
### Modifications
The stream source will add proprerties field for setting more parameter.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [x] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5071: [INLONG-5070][Manager] Add more parameter settings support for stream source
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5071:
URL: https://github.com/apache/inlong/pull/5071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5071: [INLONG-5070][Manager] Add more parameter settings support for stream source
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5071:
URL: https://github.com/apache/inlong/pull/5071#discussion_r921960983
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/source/mongodb/MongoDBSourceDTO.java:
##########
@@ -58,6 +59,9 @@ public class MongoDBSourceDTO {
@ApiModelProperty("Primary key must be shared by all tables")
private String primaryKey;
+ @ApiModelProperty("Properties for MySQL")
+ private Map<String, Object> properties;
Review Comment:
This is MongoDB, not MySQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org