You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "HomminLee (via GitHub)" <gi...@apache.org> on 2023/06/07 10:10:31 UTC

[GitHub] [dolphinscheduler] HomminLee opened a new issue, #14303: [Bug] [master/task] workflow with sub_process task can't be stop when running

HomminLee opened a new issue, #14303:
URL: https://github.com/apache/dolphinscheduler/issues/14303

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   I want to stop the workflow with 'sub_process' task, but the workflow still 'ready stop' and 'sub_process' task still running.
   
   Task state:
   <img width="1396" alt="image" src="https://github.com/apache/dolphinscheduler/assets/25881185/19207080-6fd0-4b2c-8597-335b8cdb0080">
   
   Workflow state:
   <img width="1144" alt="image" src="https://github.com/apache/dolphinscheduler/assets/25881185/3bc17561-e204-4ed9-9b37-589303302df1">
   
   'sub_process' task log:
   <img width="1131" alt="image" src="https://github.com/apache/dolphinscheduler/assets/25881185/a240eb1f-5143-4a7e-843b-837719b49eee">
   
   ---
   
   Task state should be 'kill' instead of 'stop', cause `TaskExecutionStatus` only admit kill:
   
   ```
     public boolean isFinished() {
         return isSuccess() || isKill() || isFailure() || isPause();
     }
   
     public boolean isKill() {
         return this == TaskExecutionStatus.KILL;
     }
   ```
   
   
   ### What you expected to happen
   
   Stop workflow with 'sub_process' task
   
   ### How to reproduce
   
   1. create A workflow with a shell task which will sleep 100s.
   
   <img width="918" alt="image" src="https://github.com/apache/dolphinscheduler/assets/25881185/2aaca0c9-0bc3-476f-9ef5-cd2d14fb2732">
   
   2. create B workflow with a sub_process task which point to A workflow.
   3. start B workflow.
   4. after few seconds, stop B workflow instance.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.1.x
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14303: [Bug] [master/task] workflow with sub_process task can't be stop when running

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14303:
URL: https://github.com/apache/dolphinscheduler/issues/14303#issuecomment-1627879313

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] HomminLee commented on issue #14303: [Bug] [master/task] workflow with sub_process task can't be stop when running

Posted by "HomminLee (via GitHub)" <gi...@apache.org>.
HomminLee commented on issue #14303:
URL: https://github.com/apache/dolphinscheduler/issues/14303#issuecomment-1583857901

   @ruanwenjun What does 'BLOCK' workflow state mean? What is the corresponding task status for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] closed issue #14303: [Bug] [master/task] workflow with sub_process task can't be stop when running

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #14303: [Bug] [master/task] workflow with sub_process task can't be stop when running
URL: https://github.com/apache/dolphinscheduler/issues/14303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14303: [Bug] [master/task] workflow with sub_process task can't be stop when running

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14303:
URL: https://github.com/apache/dolphinscheduler/issues/14303#issuecomment-1580388954

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14303: [Bug] [master/task] workflow with sub_process task can't be stop when running

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14303:
URL: https://github.com/apache/dolphinscheduler/issues/14303#issuecomment-1637232038

   This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org